-
Notifications
You must be signed in to change notification settings - Fork 182
WIP: Add libp2p-record
module
#925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @seetadev . If there are not others PRs about this I can start reviewing/help let me know. |
@acul71 : Definitely, Luca. I will write to you in detail today. @lla-dane will be working on this PR soon. @sumanjeet0012 is working on kad-dht refactor required in this PR. |
Hi @acul71, @codemaestro64, @seetadev — Since #890 also focuses on adding the libp2p-record module, could you clarify whether the work would be continued here or in #890? |
Hello @lla-dane, I believe this PR establishes a solid foundation for effectively addressing the linked issue and aligning with the Golang and JavaScript implementations. Subject to approval from @acul71 and @seetadev, I’d recommend building on this work moving forward. |
@codemaestro64 : Thank you so much for your initiative. Appreciate it. Since the issue was earlier assigned to @lla-dane, I checked with him today. He expressed confidence on your initial efforts and gave a go-ahead to the above PR. This is an important initiative and requires key changes in kad-dht too. @sumanjeet0012 is currently undertaking the effort to refactor kad-dht module in a separate PR. @lla-dane and @sumanjeet0012 will help you arrive at a good conclusion on this effort. Please let us know if you are stuck at any point. Would like to have this module during this month. We will get it tested by py-libp2p developers at Eth-Delhi. CCing @acul71 and @pacrob too. We will keep the other PR by @lla-dane open till we get this PR production ready for py-libp2p. |
@codemaestro64 : Re-ran the CI/CD pipeline. A good number of test cases are failing. Please collaborate with @lla-dane and @sumanjeet0012 to get them fixed. |
Alright. Thank you. |
What was wrong?
Issue #768
There was no dedicated
libp2p-record
module inpy-libp2p
, making it difficult to implement interoperable record handling, signing, and envelope support consistent with the Go and JS implementations.How was it fixed?
A new
libp2p-record
module is being introduced.So far, the following work has been completed:
Record
abstractionEnvelope
supportEnvelope
class for signing and wrapping recordsRecord
andEnvelope
Record
andEnvelope
To-Do
Record
abstractionRecord
Envelope
abstraction (signing + wrapping of records)Record
andEnvelope
Record
andEnvelope
round-trip serializationValidator
interfaceSelector
interfacecloses #768