Ping interop in py-libp2p and rust-libp2p #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lla-dane : Great, thank you so much Abhinav. Re-ran the CI/CD pipeline.1 test case is failing. Please fix the issue. |
|
@lla-dane : Wish if you could also resolve the merge conflicts. |
lla-dane
force-pushed
the
interop/py-rust
branch
from
bde71b8 to
a9c4ce9
Compare
lla-dane
changed the title
|
@lla-dane : Great, this looks resolved. Lets test the interop with rust-libp2p once. Will communicate with Luca once we are ready with final review + merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request establishes interoperability between
py-libp2pandrust-libp2p.Changes
The directory structure is similar to
./interop-testsinrust-libp2p.interop/exec/native_ping.pyinterop/exec/config: env variables for ping testinterop/arch.py:RedisClientandSwarmBuilderutilitiesinterop/lib.py:handle_ping,send_pingandrun_test(SwarmRunner) utilities