Skip to content

Supporting Logical Binop cases through symbolic pass #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2024
Merged

Supporting Logical Binop cases through symbolic pass #2709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
101f504
Supporting Logical Binop cases through symbolic pass
anutosh491 May 19, 2024
765e919
Added tests
anutosh491 May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions integration_tests/symbolics_02.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,16 @@ def test_symbolic_operations():
assert(b.is_positive == False)
assert(c.is_positive == False)

# logical binop check
l1: bool = True and p.func == Pow
l2: bool = False or p.func == Pow
l3: bool = False and u.func == Mul
l4: bool = True or u.func == Add
if p.func == Pow and u.func == Mul:
print(True)
assert(l1)
assert(l2)
assert(not l3)
assert(l4)

test_symbolic_operations()
51 changes: 51 additions & 0 deletions src/libasr/pass/replace_symbolic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,32 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
ASR::stmt_t* stmt = ASRUtils::STMT(ASR::make_Assignment_t(al, x.base.base.loc, x.m_target, function_call, nullptr));
pass_result.push_back(al, stmt);
}
} else if (ASR::is_a<ASR::LogicalBinOp_t>(*x.m_value)) {
ASR::LogicalBinOp_t* logical_binop = ASR::down_cast<ASR::LogicalBinOp_t>(x.m_value);
ASR::expr_t* function_call_left = logical_binop->m_left;
ASR::expr_t* function_call_right = logical_binop->m_right;

if (ASR::is_a<ASR::IntrinsicElementalFunction_t>(*logical_binop->m_left)) {
ASR::IntrinsicElementalFunction_t* left = ASR::down_cast<ASR::IntrinsicElementalFunction_t>(logical_binop->m_left);
if (left->m_type->type == ASR::ttypeType::Logical) {
if (is_logical_intrinsic_symbolic(logical_binop->m_left)) {
function_call_left = process_attributes(x.base.base.loc, logical_binop->m_left);
}
}
}
if (ASR::is_a<ASR::IntrinsicElementalFunction_t>(*logical_binop->m_right)) {
ASR::IntrinsicElementalFunction_t* right = ASR::down_cast<ASR::IntrinsicElementalFunction_t>(logical_binop->m_right);
if (right->m_type->type == ASR::ttypeType::Logical) {
if (is_logical_intrinsic_symbolic(logical_binop->m_right)) {
function_call_right = process_attributes(x.base.base.loc, logical_binop->m_right);
}
}
}

ASR::expr_t* new_logical_binop = ASRUtils::EXPR(ASR::make_LogicalBinOp_t(al, x.base.base.loc,
function_call_left, logical_binop->m_op, function_call_right, logical_binop->m_type, logical_binop->m_value));
ASR::stmt_t* stmt = ASRUtils::STMT(ASR::make_Assignment_t(al, x.base.base.loc, x.m_target, new_logical_binop, nullptr));
pass_result.push_back(al, stmt);
}
}

Expand Down Expand Up @@ -761,6 +787,31 @@ class ReplaceSymbolicVisitor : public PassUtils::PassVisitor<ReplaceSymbolicVisi
ASR::stmt_t* stmt = ASRUtils::STMT(ASR::make_If_t(al, xx.base.base.loc, function_call,
xx.m_body, xx.n_body, xx.m_orelse, xx.n_orelse));
pass_result.push_back(al, stmt);
} else if (ASR::is_a<ASR::LogicalBinOp_t>(*xx.m_test)) {
ASR::LogicalBinOp_t* logical_binop = ASR::down_cast<ASR::LogicalBinOp_t>(xx.m_test);
ASR::expr_t* function_call_left = logical_binop->m_left;
ASR::expr_t* function_call_right = logical_binop->m_right;

if (ASR::is_a<ASR::IntrinsicElementalFunction_t>(*logical_binop->m_left)) {
ASR::IntrinsicElementalFunction_t* left = ASR::down_cast<ASR::IntrinsicElementalFunction_t>(logical_binop->m_left);
if (left->m_type->type == ASR::ttypeType::Logical) {
if (is_logical_intrinsic_symbolic(logical_binop->m_left)) {
function_call_left = process_attributes(xx.base.base.loc, logical_binop->m_left);
}
}
}
if (ASR::is_a<ASR::IntrinsicElementalFunction_t>(*logical_binop->m_right)) {
ASR::IntrinsicElementalFunction_t* right = ASR::down_cast<ASR::IntrinsicElementalFunction_t>(logical_binop->m_right);
if (right->m_type->type == ASR::ttypeType::Logical) {
if (is_logical_intrinsic_symbolic(logical_binop->m_right)) {
function_call_right = process_attributes(xx.base.base.loc, logical_binop->m_right);
}
}
}

ASR::expr_t* new_logical_binop = ASRUtils::EXPR(ASR::make_LogicalBinOp_t(al, xx.base.base.loc,
function_call_left, logical_binop->m_op, function_call_right, logical_binop->m_type, logical_binop->m_value));
xx.m_test = new_logical_binop;
}
}

Expand Down