Skip to content

fixes semantic error for int (Issue #1926) #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2024
Merged

fixes semantic error for int (Issue #1926) #2476

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7372627
fixes semantic error for int (Issue #1926)
NishantBansal2003 Feb 4, 2024
942cffe
Improved int semantic error message with hint (Issue #1926)
NishantBansal2003 Feb 5, 2024
a95716c
Added Reference test (Issue #1926)
NishantBansal2003 Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lpython/semantics/python_ast_to_asr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,12 @@ class CommonVisitor : public AST::BaseVisitor<Struct> {
}

if( !type && raise_error ) {
throw SemanticError("Unsupported type annotation: " + var_annotation, loc);
if (var_annotation == "int") {
throw SemanticError(var_annotation + " type is not supported yet. " , loc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a hint: "hint: use i8, i16, i32 or i64 for now". Lookup other place in the code how to add a hint.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes I have made.

} else
{
throw SemanticError("Unsupported type annotation: " + var_annotation, loc);
}
}

return type;
Expand Down