Skip to content

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Aug 21, 2025

Description

Fixes: #244.

Checklist

  • Test suite updated with functionality tests
  • [~] Test suite updated with negative tests
  • Rustdoc string were added or updated
  • CHANGELOG and/or other documentation added or updated
  • [~] This is not a code change

Reviewer's checklist:

  • Any issues marked for closing are fully addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • A changelog entry is added if the change is significant
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible text
  • Doc string are properly updated

@Jakuje
Copy link
Contributor Author

Jakuje commented Aug 21, 2025

The ugly part of SLH-DSA is the signature size. This makes the test vector 36MB(!) and quite slow (therefore marked with slow feature for now).

For the release, I would probably consider stripping these tests somehow from the cargo tarballs to prevent having them needlessly large.

Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but I think we need to change the SHA3 OIDs fix

Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simo5 simo5 merged commit 88777f6 into latchset:main Sep 8, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SLH-DSA
2 participants