-
Notifications
You must be signed in to change notification settings - Fork 15
Add support for SLH-DSA #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The ugly part of SLH-DSA is the signature size. This makes the test vector 36MB(!) and quite slow (therefore marked with slow feature for now). For the release, I would probably consider stripping these tests somehow from the cargo tarballs to prevent having them needlessly large. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but I think we need to change the SHA3 OIDs fix
Upstream issue: pyca/cryptography#13331 Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes: #244.
Checklist
Reviewer's checklist: