-
Notifications
You must be signed in to change notification settings - Fork 15
Add PKCS#11 3.2 attribute to NSSDB storage #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This catches up nssdb to the changes happenning in NSS upstream Signed-off-by: Simo Sorce <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering how the PQC algorithm tests worked before this with the NSS DB when the new attributes like Encapsulate, ParamSet and others could not have been stored in the database ....
* attributes and if so just fail immediately. | ||
* Do this only for private objects otherwise we incorrectly | ||
* match attributes like CKA_VALUE in public objects. */ | ||
if do_private && is_sensitive_attribute(attr.type_) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have a simple regression test for this to make sure this works in both db backends correctly?
Good q, I think they simply always use the sqlite database, we'll have to figure out how to make sure most test are also tried on nssdb, perhaps a build target that has only the nssdb ? |
Thats not how I wrote that. When nssdb is enabled, it should default to NSSDB, unless something changed since I did this: Line 191 in 461010b
|
I think I changed that because at some point all CI jobs included nssdb, and that means sqlite was never tested, so I think I change something and then forgot about it. Maybe we should open a separate issue to follow up on this? |
Marking this as draft because I think we need to add at least a test that will upgrade a database with the new attributes and work correctly after doing that |
Description
This catches up nssdb to the changes happenning in NSS upstream
Fixes #307
Checklist
Reviewer's checklist: