Windows support

[ivozeba]

First and foremost, very cool project :)!

Are there any plans or is there any interest to support windows? I wanted to ask before investing time into a PR.

In case there is interest, I've got a dirty local copy that successfully builds on Windows but to clean it up the following work needs to be done (which I'd look to do as part of the PR):

• conditionally replace/abstract away libc with winsys in:
  • conformance
  • migration
• modify build to detect windows:
  • expect libcrypto_static?
  • add include path for openssl (openssl source directory/include/)
  • add include path for C headers (CRT?)
  • link against Crypt32
  • link against User32
  • add library path for installed msvc

Although it builds, I am unable to initialize via the cli, it states that it does not find the cryptoki library - very likely something with the path resolution (also to be looked at as part of the PR).

Is there anything else that would be required from a maintainers point of view?

[simo5]

As long as you can supply a CI job that tests Windows support and are willing to keep an eye here for Windows specific question we can certainly enable windows builds.

The key factor here is maintainability.

[ivozeba]

Understood and that was the intention.

I've managed to get it running after re-discovering some alignment issues - I'll look to start cleaning up/running tests to see if there is anything else funky before submitting a PR.

There'll be follow up questions I'm certain :).

[simo5]

Yeah on windows usually structures are packed, while on *nix they are not, I do not know how you deal with that with Rust FFI

[ivozeba]

I gained a little experience recently debugging struct packing issues on rust-cryptoki.

I expect the questions will be centered around build variants and hopefully only test case modifications. Still playing with what I have and looking for minimal code changes so I'll circle back once the questions are clear for me to ask.

[simo5]

I suggest you test rust-cryptoki by loading an actual pkcs#11 driver available for windows, like the yubikey driver or similar.
Then you have some chance of ensuring you have the right packing.

[ivozeba]

I've already tested rust-cryptoki on Windows against a vendor pkcs11 implementation - I haven't tested all calls but the usual suspects worked:

• init
• login
• find object
• get attribute value
• sign
• verify

[simo5]

That should be enough to ensure packing is correct.