Skip to content

Conversation

gabrielbosio
Copy link
Collaborator

This PR serves as a proposal to add a check for the creation of a FieldElement from a hex string.

See starknet-io/types-rs#81 for further details.

Note that this is one of two alternatives mentioned. The other alternative is to add this check in the from_hex function from types-rs.

@gabrielbosio gabrielbosio force-pushed the finetune_felt_from_hex_check branch 2 times, most recently from d491d1c to b4feace Compare September 23, 2025 15:17
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.18%. Comparing base (160bb5c) to head (62697a5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1020   +/-   ##
=======================================
  Coverage   70.17%   70.18%           
=======================================
  Files         165      165           
  Lines       32770    32778    +8     
=======================================
+ Hits        22996    23004    +8     
  Misses       9774     9774           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gabrielbosio gabrielbosio marked this pull request as ready for review September 23, 2025 15:44
@gabrielbosio gabrielbosio requested a review from a team as a code owner September 23, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants