Skip to content

Conversation

kitloong
Copy link
Contributor

Fixes

echo-jwt/jwt.go

Lines 159 to 161 in 6944ffe

// For valid token, it sets the user in context and calls next handler.
// For invalid token, it returns "401 - Unauthorized" error.
// For missing token, it returns "400 - Bad Request" error.

https://echo.labstack.com/docs/middleware/jwt

Should return HTTP status 400 if missing JWT as documented.

@kitloong
Copy link
Contributor Author

Hi @aldas

I am sorry, just a kind reminder to review in case you have missed this, thank you!

Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit 2fe4a09 into labstack:main Jul 28, 2023
@kitloong kitloong deleted the feature/400 branch July 28, 2023 06:28
andreasgerstmayr added a commit to perses/perses that referenced this pull request Feb 18, 2025
Nexucis pushed a commit to perses/perses that referenced this pull request Feb 24, 2025
* Bump github.com/labstack/echo-jwt/v4 from 4.2.0 to 4.3.0

Bumps [github.com/labstack/echo-jwt/v4](https://github.com/labstack/echo-jwt) from 4.2.0 to 4.3.0.
- [Release notes](https://github.com/labstack/echo-jwt/releases)
- [Changelog](https://github.com/labstack/echo-jwt/blob/main/CHANGELOG.md)
- [Commits](labstack/echo-jwt@v4.2.0...v4.3.0)

---
updated-dependencies:
- dependency-name: github.com/labstack/echo-jwt/v4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* update expected status code

Ref. labstack/echo-jwt#13

Signed-off-by: Andreas Gerstmayr <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Andreas Gerstmayr <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andreas Gerstmayr <[email protected]>
zoriya added a commit to zoriya/Kyoo that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants