backfill missed data due to error from querying analytics #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Team, Can someone please review this PR? This change will be super useful |
|
@martinhaus Can you please review and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are occasionally seeing 0 request count minute-by-minute in cloudflare_zone_* timeseries as shown in the first screenshot below due to
graphql: Internal server error. This PR backfills the missing data in the subsequent interval by taking into account the last minute that it was successful, in the GraphQL query. Request count would appear to have doubled in the next interval, as shown in the second screenshot, but in reality it actually accounts for the missing data in the previous interval. This does not implement a retry mechanism because CloudFlare has imposed a strict rate-limiting.