Skip to content
This repository was archived by the owner on Sep 15, 2022. It is now read-only.

Use external documentation in GCP Broker instead of local one #114

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Use external documentation in GCP Broker instead of local one #114

merged 1 commit into from
Aug 26, 2019

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Aug 24, 2019 •
edited
Loading

Description

Changes proposed in this pull request:

  • remove copied doc from GCP Broker
  • use doc from external upstream
  • remove the redis docs cause it was disabled in upstream repo
  • use the official GCP Broker image

All changes were tested on cluster. I also created the Google CloudSQL for MySQL instance and binding to it.

You can test it by yourself using such cfg:

apiVersion: addons.kyma-project.io/v1alpha1
kind: ClusterAddonsConfiguration
metadata:
  name: addons-configuration-imaginary-beach
spec:
  repositories:
  - url: git::https://github.com/mszostok/addons.git//addons/index-gcp.yaml?ref=change-gcp-docs

Related issue(s)

@mszostok
Use external documentation in GCP Broker instead of local one
cb82662 
- remove copied doc from GCP Broker
- use doc from external upstream
- remove the redis docs cause it was disabled in upstream repo
- use the official GCP Broker image
@mszostok mszostok added area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature. labels Aug 24, 2019
@mszostok mszostok marked this pull request as ready for review August 24, 2019 20:02
@mszostok mszostok mentioned this pull request Aug 24, 2019
Closed
polskikiel
polskikiel approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@polskikiel polskikiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested lgtm

@mszostok mszostok merged commit 3133590 into kyma-project:master Aug 26, 2019
@mszostok mszostok deleted the change-gcp-docs branch August 26, 2019 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamwalach adamwalach Awaiting requested review from adamwalach

@aszecowka aszecowka Awaiting requested review from aszecowka

@bszwarc bszwarc Awaiting requested review from bszwarc

@jasiu001 jasiu001 Awaiting requested review from jasiu001

@kazydek kazydek Awaiting requested review from kazydek

@mmitoraj mmitoraj Awaiting requested review from mmitoraj mmitoraj is a code owner

@piotrmiskiewicz piotrmiskiewicz Awaiting requested review from piotrmiskiewicz piotrmiskiewicz is a code owner

@PK85 PK85 Awaiting requested review from PK85 PK85 is a code owner

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

2 more reviewers

@polskikiel polskikiel polskikiel approved these changes

@klaudiagrz klaudiagrz klaudiagrz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mszostok @polskikiel @klaudiagrz