Drop macros new #5999
Open
Drop macros new #5999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasonlmx
requested review from
andyfengHKU,
acquamarin and
ray6080
and removed request for
benjaminwinger
ray6080
approved these changes
Sep 10, 2025
| @@ -97,6 +100,34 @@ void Drop::dropTable(const main::ClientContext* context) { | |||
| catalog->dropTableEntryAndIndex(transaction, dropInfo.name); | |||
| appendMessage(stringFormat("Table {} has been dropped.", dropInfo.name), memoryManager); | |||
| } | |||
There was a problem hiding this comment.
Add a line in between here.
Benchmark ResultMaster commit hash: No major diffs! Other queries
|
Jasonlmx
force-pushed
the
drop-macros-new
branch
from
7809a9e to
9f831a9
Compare
Jasonlmx
force-pushed
the
drop-macros-new
branch
from
737a463 to
021d44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for dropping macros.
Add test: commit, rollback, recovery on drop macro
Fixed:
Issue #5943, dropping macros