Skip to content

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Sep 9, 2025

Description

  1. Avoid dangling pointer of VectorUpdateInfo* info during rollback. Instead, we use version to fetch the correct VectorUpdateInfo to be rolled back.
  2. Fix the case when rolling back the head of the version chain, where we didn't correctly reset prev version's next to nullptr.

Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.76%. Comparing base (1256974) to head (e0956e2).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5994      +/-   ##
==========================================
- Coverage   86.32%   85.76%   -0.56%     
==========================================
  Files        1456     1642     +186     
  Lines       65790    75827   +10037     
  Branches     8029     9021     +992     
==========================================
+ Hits        56793    65036    +8243     
- Misses       8739    10530    +1791     
- Partials      258      261       +3     
Flag Coverage Δ
extension 63.55% <41.17%> (?)
in-mem 81.01% <100.00%> (-0.01%) ⬇️
on-disk 86.39% <100.00%> (-0.01%) ⬇️
recovery 86.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ray6080 ray6080 marked this pull request as ready for review September 10, 2025 00:30
@ray6080 ray6080 changed the title Avoid using dangling VectorUpdateInfo pointer during rollback Fix concurrent rollback of updates to the same Vector Sep 10, 2025
Copy link

github-actions bot commented Sep 10, 2025

Benchmark Result

Master commit hash: 035a5b491c8f0e7574ce82d247a9619a9f0bcde0
Branch commit hash: 9640c42eb48a6d330b2cdb1abcbc551d460464cf

No major diffs!

Other queries
Query Group Query Name Mean Time - Commit (ms)
aggregation q24 704.15
aggregation q28 7734.72
filter q14 60.19
filter q15 65.02
filter q16 277.53
filter q17 382.64
filter q18 1848.88
filter zonemap-node 25.26
filter zonemap-node-lhs-cast 25.23
filter zonemap-node-null 24.81
filter zonemap-rel 5483.77
fixed_size_expr_evaluator q07 620.68
fixed_size_expr_evaluator q08 911.93
fixed_size_expr_evaluator q09 903.71
fixed_size_expr_evaluator q10 191.57
fixed_size_expr_evaluator q11 190.63
fixed_size_expr_evaluator q12 168.52
fixed_size_expr_evaluator q13 1498.85
fixed_size_seq_scan q23 54.54
join q29 775.13
join q30 1681.15
join q31 7.37
join SelectiveTwoHopJoin 45.52
ldbc_snb_ic q35 10.61
ldbc_snb_ic q36 98.28
ldbc_snb_is q32 2.16
ldbc_snb_is q33 16.69
ldbc_snb_is q34 1.02
limit push-down-limit-into-distinct 2019.69
multi-rel multi-rel-large-scan 1452.84
multi-rel multi-rel-lookup 10.32
multi-rel multi-rel-small-scan 172.18
order_by q25 66.21
order_by q26 382.25
order_by q27 1297.51
recursive_join recursive-join-bidirection 324.54
recursive_join recursive-join-dense 7103.96
recursive_join recursive-join-path 23763.78
recursive_join recursive-join-sparse 5.88
recursive_join recursive-join-trail 7041.20
scan_after_filter q01 106.89
scan_after_filter q02 93.26
shortest_path_ldbc100 q37 147.53
shortest_path_ldbc100 q38 310.30
shortest_path_ldbc100 q39 88.79
shortest_path_ldbc100 q40 538.38
var_size_expr_evaluator q03 2097.17
var_size_expr_evaluator q04 2146.10
var_size_expr_evaluator q05 2571.20
var_size_expr_evaluator q06 1268.88
var_size_seq_scan q19 1348.43
var_size_seq_scan q20 2563.58
var_size_seq_scan q21 2196.09
var_size_seq_scan q22 107.99

@andyfengHKU andyfengHKU merged commit bcbfabd into master Sep 10, 2025
53 of 54 checks passed
@andyfengHKU andyfengHKU deleted the update-info-2 branch September 10, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants