-
Notifications
You must be signed in to change notification settings - Fork 202
Fix LSQB benchmark runs #5820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LSQB benchmark runs #5820
Conversation
benchmark/lsqb/benchmark_runner.py
Outdated
@@ -126,7 +126,7 @@ def run_query(conn, query_spec): | |||
|
|||
|
|||
def run_kuzu(sf, serialized_graph_path, num_threads): | |||
db = kuzu.Database(serialized_graph_path) | |||
db = kuzu.Database(os.path.join(serialized_graph_path, "kuzu.db")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we use db.kuzu
instead (or <something>.kuzu
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure.
Benchmark ResultMaster commit hash:
Other queries
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5820 +/- ##
==========================================
- Coverage 85.95% 85.95% -0.01%
==========================================
Files 1620 1620
Lines 73587 73587
Branches 8803 8803
==========================================
- Hits 63253 63251 -2
- Misses 10109 10111 +2
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fix lsqb benchmark serialization after single file database change
Description
The LSQB benchmark failed due to the change of single file database. Not we need to pass in a file path instead of a directory to construct a Kuzu Database.