Skip to content

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jul 28, 2025

Description

The LSQB benchmark failed due to the change of single file database. Not we need to pass in a file path instead of a directory to construct a Kuzu Database.

@ray6080 ray6080 requested a review from mewim July 28, 2025 17:21
@@ -126,7 +126,7 @@ def run_query(conn, query_spec):


def run_kuzu(sf, serialized_graph_path, num_threads):
db = kuzu.Database(serialized_graph_path)
db = kuzu.Database(os.path.join(serialized_graph_path, "kuzu.db"))
Copy link
Contributor

@sdht0 sdht0 Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we use db.kuzu instead (or <something>.kuzu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

Copy link

github-actions bot commented Jul 28, 2025

Benchmark Result

Master commit hash: 6f593302aa546ba6507dd022214143a8e89f5b10
Branch commit hash: 1c851bf61feea2a22c7b67358503d9fa648bb944

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
join SelectiveTwoHopJoin 45.32 57.88 -12.55 (-21.69%)
ldbc_snb_is q33 14.03 10.99 3.04 (27.62%)
multi-rel multi-rel-small-scan 156.14 210.35 -54.22 (-25.77%)
Other queries
Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 703.54 703.73 -0.19 (-0.03%)
aggregation q28 7755.86 7737.82 18.03 (0.23%)
filter q14 59.31 60.53 -1.22 (-2.02%)
filter q15 61.92 61.01 0.91 (1.49%)
filter q16 273.37 273.50 -0.13 (-0.05%)
filter q17 379.80 382.35 -2.55 (-0.67%)
filter q18 1814.02 1817.13 -3.11 (-0.17%)
filter zonemap-node 23.90 23.57 0.33 (1.39%)
filter zonemap-node-lhs-cast 23.91 23.57 0.34 (1.44%)
filter zonemap-node-null 23.58 23.23 0.35 (1.51%)
filter zonemap-rel 5173.15 5265.82 -92.68 (-1.76%)
fixed_size_expr_evaluator q07 627.51 627.05 0.46 (0.07%)
fixed_size_expr_evaluator q08 914.99 915.65 -0.65 (-0.07%)
fixed_size_expr_evaluator q09 915.18 914.93 0.25 (0.03%)
fixed_size_expr_evaluator q10 198.45 198.65 -0.21 (-0.11%)
fixed_size_expr_evaluator q11 198.98 197.16 1.82 (0.92%)
fixed_size_expr_evaluator q12 176.11 176.26 -0.16 (-0.09%)
fixed_size_expr_evaluator q13 1497.51 1500.82 -3.31 (-0.22%)
fixed_size_seq_scan q23 52.99 56.24 -3.24 (-5.77%)
join q29 784.10 750.88 33.22 (4.42%)
join q30 1835.86 1784.95 50.91 (2.85%)
join q31 4.59 5.74 -1.14 (-19.92%)
ldbc_snb_ic q35 9.84 9.88 -0.04 (-0.45%)
ldbc_snb_ic q36 96.22 95.22 1.00 (1.05%)
ldbc_snb_is q32 2.93 2.59 0.35 (13.39%)
ldbc_snb_is q34 1.21 1.27 -0.06 (-4.41%)
limit push-down-limit-into-distinct 2036.04 2003.86 32.18 (1.61%)
multi-rel multi-rel-large-scan 1420.32 1450.23 -29.91 (-2.06%)
multi-rel multi-rel-lookup 5.90 5.32 0.58 (10.87%)
order_by q25 65.22 68.91 -3.69 (-5.35%)
order_by q26 383.75 386.32 -2.56 (-0.66%)
order_by q27 1302.98 1296.90 6.08 (0.47%)
recursive_join recursive-join-bidirection 375.52 390.83 -15.30 (-3.92%)
recursive_join recursive-join-dense 7110.93 7079.77 31.15 (0.44%)
recursive_join recursive-join-path 23345.31 23376.05 -30.74 (-0.13%)
recursive_join recursive-join-sparse 9.74 10.88 -1.14 (-10.46%)
recursive_join recursive-join-trail 7084.40 7037.67 46.73 (0.66%)
scan_after_filter q01 115.77 112.52 3.25 (2.89%)
scan_after_filter q02 96.26 90.44 5.81 (6.43%)
shortest_path_ldbc100 q37 79.89 80.33 -0.44 (-0.54%)
shortest_path_ldbc100 q38 348.98 359.33 -10.35 (-2.88%)
shortest_path_ldbc100 q39 81.04 89.56 -8.52 (-9.51%)
shortest_path_ldbc100 q40 530.99 541.12 -10.13 (-1.87%)
var_size_expr_evaluator q03 2122.80 2119.37 3.44 (0.16%)
var_size_expr_evaluator q04 2104.79 2114.85 -10.06 (-0.48%)
var_size_expr_evaluator q05 2613.12 2601.30 11.82 (0.45%)
var_size_expr_evaluator q06 1260.66 1264.62 -3.96 (-0.31%)
var_size_seq_scan q19 1353.61 1346.35 7.26 (0.54%)
var_size_seq_scan q20 2236.04 2236.36 -0.32 (-0.01%)
var_size_seq_scan q21 2168.47 2176.48 -8.00 (-0.37%)
var_size_seq_scan q22 110.87 110.05 0.82 (0.75%)

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.95%. Comparing base (6f59330) to head (4919723).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5820      +/-   ##
==========================================
- Coverage   85.95%   85.95%   -0.01%     
==========================================
  Files        1620     1620              
  Lines       73587    73587              
  Branches     8803     8803              
==========================================
- Hits        63253    63251       -2     
- Misses      10109    10111       +2     
  Partials      225      225              
Flag Coverage Δ
extension 63.35% <ø> (-0.01%) ⬇️
in-mem 81.68% <ø> (-0.01%) ⬇️
on-disk 86.55% <ø> (+<0.01%) ⬆️
recovery 86.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andyfengHKU andyfengHKU merged commit cf17ac5 into master Jul 29, 2025
49 of 54 checks passed
@andyfengHKU andyfengHKU deleted the benchmark branch July 29, 2025 01:24
acquamarin pushed a commit that referenced this pull request Aug 5, 2025
* fix lsqb benchmark serialization after single file database change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants