Skip to content

Conversation

05st
Copy link
Contributor

@05st 05st commented Jun 9, 2025

Fixes #5397

The issue was tempTableNames was not being populated correctly due to the regex expression matching more than it needed, so the expression fed into std::regex contained extra parenthesis due to string concatenation with the table name.

@05st 05st requested review from ray6080 and andyfengHKU June 9, 2025 15:46
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (f40b4e6) to head (6e35c18).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5514      +/-   ##
==========================================
- Coverage   86.58%   86.57%   -0.02%     
==========================================
  Files        1422     1423       +1     
  Lines       62492    62615     +123     
  Branches     7656     7686      +30     
==========================================
+ Hits        54110    54209      +99     
- Misses       8203     8227      +24     
  Partials      179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Jun 9, 2025

Benchmark Result

Master commit hash: 2c39129f27bd8298080c1ed03d038a6e4c187d10
Branch commit hash: 99ca1621b82fdef8a40dd1e7d982303ca13ce132

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 663.72 664.44 -0.72 (-0.11%)
aggregation q28 6522.00 6554.76 -32.76 (-0.50%)
filter q14 60.12 59.61 0.51 (0.86%)
filter q15 59.48 58.47 1.01 (1.73%)
filter q16 274.20 277.99 -3.79 (-1.36%)
filter q17 387.39 380.39 7.00 (1.84%)
filter q18 1824.75 1854.74 -29.98 (-1.62%)
filter zonemap-node 22.91 22.49 0.42 (1.85%)
filter zonemap-node-lhs-cast 23.18 22.62 0.56 (2.45%)
filter zonemap-node-null 22.75 22.42 0.34 (1.50%)
filter zonemap-rel 5737.35 5840.77 -103.42 (-1.77%)
fixed_size_expr_evaluator q07 620.05 619.89 0.16 (0.03%)
fixed_size_expr_evaluator q08 900.61 902.47 -1.85 (-0.21%)
fixed_size_expr_evaluator q09 903.99 903.04 0.94 (0.10%)
fixed_size_expr_evaluator q10 191.70 191.59 0.11 (0.06%)
fixed_size_expr_evaluator q11 191.58 191.07 0.50 (0.26%)
fixed_size_expr_evaluator q12 167.59 167.64 -0.06 (-0.03%)
fixed_size_expr_evaluator q13 1489.60 1502.30 -12.69 (-0.85%)
fixed_size_seq_scan q23 44.36 45.64 -1.28 (-2.81%)
join q29 755.02 736.44 18.59 (2.52%)
join q30 1552.99 1706.96 -153.96 (-9.02%)
join q31 5.32 5.02 0.29 (5.87%)
join SelectiveTwoHopJoin 51.31 39.62 11.69 (29.50%)
ldbc_snb_ic q35 8.45 8.18 0.27 (3.30%)
ldbc_snb_ic q36 81.42 96.00 -14.57 (-15.18%)
ldbc_snb_is q32 6.76 3.62 3.14 (86.62%)
ldbc_snb_is q33 16.13 11.10 5.03 (45.28%)
ldbc_snb_is q34 1.20 1.30 -0.11 (-8.10%)
limit push-down-limit-into-distinct 1955.59 1945.09 10.50 (0.54%)
multi-rel multi-rel-large-scan 1756.37 1762.74 -6.37 (-0.36%)
multi-rel multi-rel-lookup 10.75 8.74 2.01 (22.97%)
multi-rel multi-rel-small-scan 174.20 203.50 -29.30 (-14.40%)
order_by q25 63.34 67.05 -3.72 (-5.54%)
order_by q26 381.29 385.22 -3.93 (-1.02%)
order_by q27 1315.01 1315.82 -0.81 (-0.06%)
recursive_join recursive-join-bidirection 364.89 364.50 0.39 (0.11%)
recursive_join recursive-join-dense 6926.08 7015.25 -89.17 (-1.27%)
recursive_join recursive-join-path 23235.30 23692.33 -457.03 (-1.93%)
recursive_join recursive-join-sparse 8.89 10.51 -1.62 (-15.40%)
recursive_join recursive-join-trail 6885.30 6986.80 -101.50 (-1.45%)
scan_after_filter q01 104.82 103.19 1.64 (1.59%)
scan_after_filter q02 90.47 91.68 -1.21 (-1.32%)
shortest_path_ldbc100 q37 76.22 81.05 -4.84 (-5.97%)
shortest_path_ldbc100 q38 331.14 324.08 7.07 (2.18%)
shortest_path_ldbc100 q39 87.58 86.71 0.87 (1.00%)
shortest_path_ldbc100 q40 515.17 506.35 8.82 (1.74%)
var_size_expr_evaluator q03 2044.24 2089.33 -45.09 (-2.16%)
var_size_expr_evaluator q04 2107.29 2135.48 -28.19 (-1.32%)
var_size_expr_evaluator q05 2597.36 2638.81 -41.45 (-1.57%)
var_size_expr_evaluator q06 1284.51 1291.67 -7.16 (-0.55%)
var_size_seq_scan q19 1352.96 1360.12 -7.16 (-0.53%)
var_size_seq_scan q20 2751.56 2780.05 -28.49 (-1.02%)
var_size_seq_scan q21 2176.32 2200.51 -24.19 (-1.10%)
var_size_seq_scan q22 111.94 110.38 1.56 (1.41%)

@05st 05st changed the title Fix invalid regex expressions occuring due to nested parenthesis Fix invalid regex expressions occuring due to nested parentheses Jun 9, 2025
@ray6080 ray6080 removed their request for review June 9, 2025 20:19
@05st 05st merged commit 708d32e into master Jun 10, 2025
46 of 52 checks passed
@05st 05st deleted the shell-fix branch June 10, 2025 14:44
tgahunia05 pushed a commit that referenced this pull request Jun 11, 2025
* Fix regex error

* Add test

* Add assert to test

* Attempt to fix shell test

* Actually fix shell test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shell: crash when attempting to wrap match query inside parentheses
2 participants