Skip to content

Conversation

mewim
Copy link
Member

@mewim mewim commented May 14, 2025

Reverts #5401

Copy link
Contributor

@sdht0 sdht0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (afa2cfe) to head (1acff82).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5415      +/-   ##
==========================================
- Coverage   86.88%   86.88%   -0.01%     
==========================================
  Files        1414     1414              
  Lines       62004    62004              
  Branches     7584     7585       +1     
==========================================
- Hits        53875    53871       -4     
- Misses       7954     7958       +4     
  Partials      175      175              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Benchmark Result

Master commit hash: afa2cfe5210505219a4fda15b7a0d07ba7788989
Branch commit hash: e8fd59b90c4552e0262a0975c7a970ede2bc32d3

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 664.39 668.56 -4.16 (-0.62%)
aggregation q28 6525.64 6624.93 -99.30 (-1.50%)
filter q14 63.05 59.00 4.05 (6.87%)
filter q15 62.72 65.08 -2.36 (-3.62%)
filter q16 277.86 276.19 1.68 (0.61%)
filter q17 379.78 378.91 0.87 (0.23%)
filter q18 1865.74 1847.94 17.79 (0.96%)
filter zonemap-node 24.58 24.22 0.36 (1.49%)
filter zonemap-node-lhs-cast 24.73 24.27 0.47 (1.93%)
filter zonemap-node-null 24.65 24.18 0.47 (1.94%)
filter zonemap-rel 5474.63 5445.04 29.60 (0.54%)
fixed_size_expr_evaluator q07 616.99 618.27 -1.27 (-0.21%)
fixed_size_expr_evaluator q08 900.98 904.13 -3.15 (-0.35%)
fixed_size_expr_evaluator q09 901.24 902.07 -0.84 (-0.09%)
fixed_size_expr_evaluator q10 190.53 190.28 0.25 (0.13%)
fixed_size_expr_evaluator q11 190.26 191.54 -1.28 (-0.67%)
fixed_size_expr_evaluator q12 167.85 168.11 -0.26 (-0.15%)
fixed_size_expr_evaluator q13 1498.77 1500.84 -2.07 (-0.14%)
fixed_size_seq_scan q23 53.72 48.87 4.85 (9.93%)
join q29 735.97 701.08 34.89 (4.98%)
join q30 1562.94 1577.94 -15.00 (-0.95%)
join q31 8.86 4.32 4.53 (104.79%)
join SelectiveTwoHopJoin 44.66 38.19 6.47 (16.94%)
ldbc_snb_ic q35 9.67 8.60 1.07 (12.40%)
ldbc_snb_ic q36 99.27 87.13 12.13 (13.92%)
ldbc_snb_is q32 4.58 2.79 1.80 (64.45%)
ldbc_snb_is q33 11.14 14.45 -3.30 (-22.86%)
ldbc_snb_is q34 1.41 1.25 0.17 (13.55%)
limit push-down-limit-into-distinct 2125.12 2031.33 93.79 (4.62%)
multi-rel multi-rel-large-scan 1692.33 1676.80 15.53 (0.93%)
multi-rel multi-rel-lookup 10.66 9.54 1.12 (11.78%)
multi-rel multi-rel-small-scan 201.70 202.82 -1.12 (-0.55%)
order_by q25 68.41 63.20 5.21 (8.24%)
order_by q26 396.18 388.68 7.50 (1.93%)
order_by q27 1351.86 1355.56 -3.71 (-0.27%)
recursive_join recursive-join-bidirection 364.56 377.27 -12.71 (-3.37%)
recursive_join recursive-join-dense 6420.86 7007.65 -586.80 (-8.37%)
recursive_join recursive-join-path 23194.35 23428.26 -233.91 (-1.00%)
recursive_join recursive-join-sparse 9.83 10.59 -0.76 (-7.16%)
recursive_join recursive-join-trail 6778.13 6981.55 -203.42 (-2.91%)
scan_after_filter q01 107.42 102.91 4.51 (4.38%)
scan_after_filter q02 92.24 88.73 3.51 (3.95%)
shortest_path_ldbc100 q37 88.34 77.98 10.36 (13.29%)
shortest_path_ldbc100 q38 296.97 341.37 -44.40 (-13.01%)
shortest_path_ldbc100 q39 88.81 87.21 1.61 (1.84%)
shortest_path_ldbc100 q40 427.40 518.12 -90.73 (-17.51%)
var_size_expr_evaluator q03 2116.94 2056.33 60.60 (2.95%)
var_size_expr_evaluator q04 2219.48 2174.13 45.35 (2.09%)
var_size_expr_evaluator q05 2722.96 2660.37 62.59 (2.35%)
var_size_expr_evaluator q06 1316.43 1282.74 33.69 (2.63%)
var_size_seq_scan q19 1430.00 1387.90 42.11 (3.03%)
var_size_seq_scan q20 2471.92 2333.87 138.05 (5.92%)
var_size_seq_scan q21 2303.02 2213.12 89.90 (4.06%)
var_size_seq_scan q22 116.16 109.94 6.22 (5.66%)

@ray6080 ray6080 merged commit f5bbfec into master May 15, 2025
28 checks passed
@ray6080 ray6080 deleted the revert-5401-skip-gcs-test branch May 15, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants