Ease the type check on WASM prepared statement #5394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR relaxes the validation of WASM PreparedStatement objects and parameter objects to avoid failures in minified builds.
- Updated the test for parameter validation to use null instead of a non-plain object.
- Modified error messages and validation logic for both preparedStatement and params in the connection implementation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/wasm/test/test_connection.js | Updated the test case to expect a null parameter and a modified error message. |
| tools/wasm/src_js/sync/connection.js | Relaxed the preparedStatement type check and updated the error messages and parameter validation. |
Comments suppressed due to low confidence (1)
tools/wasm/test/test_connection.js:104
- [nitpick] Consider adding tests for other invalid parameter types (e.g., non-object truthy values) to ensure that the validation logic in the connection always behaves as expected.
await conn.execute(preparedStatement, null);
Comment on lines
127
to
130
| if (!preparedStatement || | ||
| typeof preparedStatement !== "object" || | ||
| preparedStatement.constructor.name !== "PreparedStatement" || | ||
| preparedStatement._isClosed) { | ||
| throw new Error("preparedStatement must be a valid PreparedStatement object."); | ||
| throw new Error("preparedStatement is not valid or is closed."); | ||
| } |
There was a problem hiding this comment.
[nitpick] The error message for an invalid or closed PreparedStatement is now combined; consider splitting the checks for a more granular error message to make debugging easier.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current check for
PreparedStatementobject for WASM is too strong. In some minified build process, it can cause errors, because the constructor name is shotened and thePreparedStatementclass name is no longer kept, causing the check to fail despite the object is valid.