Skip to content

Conversation

acquamarin
Copy link
Contributor

Add doc example for neo4j extension, also add install/load tests.
Rename neo4j_migration -> neo4j

Copy link

Benchmark Result

Master commit hash: 8fc35153192e63702385477f917c6a90e588c0c1
Branch commit hash: f1f5430ed10d4ccbb5d8bce8d185210854616ffc

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 721.66 722.30 -0.64 (-0.09%)
aggregation q28 6562.21 6552.57 9.64 (0.15%)
filter q14 119.18 118.11 1.06 (0.90%)
filter q15 115.86 117.37 -1.51 (-1.28%)
filter q16 338.13 333.89 4.24 (1.27%)
filter q17 438.00 437.53 0.47 (0.11%)
filter q18 1922.49 1923.06 -0.56 (-0.03%)
filter zonemap-node 79.71 80.14 -0.43 (-0.53%)
filter zonemap-node-lhs-cast 81.60 80.26 1.34 (1.67%)
filter zonemap-node-null 79.59 80.16 -0.57 (-0.71%)
filter zonemap-rel 5753.46 5789.60 -36.15 (-0.62%)
fixed_size_expr_evaluator q07 674.04 679.50 -5.46 (-0.80%)
fixed_size_expr_evaluator q08 959.29 965.11 -5.82 (-0.60%)
fixed_size_expr_evaluator q09 958.53 962.62 -4.09 (-0.42%)
fixed_size_expr_evaluator q10 247.54 253.69 -6.14 (-2.42%)
fixed_size_expr_evaluator q11 248.89 254.39 -5.49 (-2.16%)
fixed_size_expr_evaluator q12 228.29 232.11 -3.81 (-1.64%)
fixed_size_expr_evaluator q13 1560.16 1556.53 3.63 (0.23%)
fixed_size_seq_scan q23 102.53 110.50 -7.97 (-7.21%)
join q29 739.32 767.44 -28.12 (-3.66%)
join q30 1749.31 1739.14 10.17 (0.58%)
join q31 5.88 6.17 -0.29 (-4.64%)
join SelectiveTwoHopJoin 44.08 54.85 -10.77 (-19.64%)
ldbc_snb_ic q35 10.16 6.72 3.43 (51.08%)
ldbc_snb_ic q36 80.67 92.56 -11.89 (-12.84%)
ldbc_snb_is q32 6.17 4.71 1.46 (31.05%)
ldbc_snb_is q33 15.26 15.39 -0.14 (-0.89%)
ldbc_snb_is q34 1.36 1.26 0.10 (8.11%)
limit push-down-limit-into-distinct 1971.09 1924.10 46.99 (2.44%)
multi-rel multi-rel-large-scan 1693.29 1759.77 -66.48 (-3.78%)
multi-rel multi-rel-lookup 11.19 10.99 0.20 (1.79%)
multi-rel multi-rel-small-scan 205.13 202.89 2.24 (1.10%)
order_by q25 121.53 120.88 0.65 (0.54%)
order_by q26 435.55 440.83 -5.28 (-1.20%)
order_by q27 1364.80 1393.22 -28.42 (-2.04%)
recursive_join recursive-join-bidirection 369.35 348.94 20.41 (5.85%)
recursive_join recursive-join-dense 7094.74 7103.93 -9.19 (-0.13%)
recursive_join recursive-join-path 23536.82 23313.22 223.60 (0.96%)
recursive_join recursive-join-sparse 10.97 8.31 2.66 (31.98%)
recursive_join recursive-join-trail 6984.17 7010.71 -26.54 (-0.38%)
scan_after_filter q01 161.18 160.12 1.06 (0.66%)
scan_after_filter q02 145.72 146.39 -0.68 (-0.46%)
shortest_path_ldbc100 q37 77.23 72.86 4.37 (5.99%)
shortest_path_ldbc100 q38 334.00 337.52 -3.52 (-1.04%)
shortest_path_ldbc100 q39 85.56 86.13 -0.57 (-0.66%)
shortest_path_ldbc100 q40 495.75 516.50 -20.74 (-4.02%)
var_size_expr_evaluator q03 2069.49 2091.77 -22.27 (-1.06%)
var_size_expr_evaluator q04 2184.37 2204.49 -20.12 (-0.91%)
var_size_expr_evaluator q05 2595.85 2585.79 10.06 (0.39%)
var_size_expr_evaluator q06 1330.57 1333.71 -3.14 (-0.24%)
var_size_seq_scan q19 1411.99 1406.90 5.09 (0.36%)
var_size_seq_scan q20 2768.27 2797.32 -29.05 (-1.04%)
var_size_seq_scan q21 2248.50 2235.42 13.08 (0.59%)
var_size_seq_scan q22 132.67 125.67 7.00 (5.57%)

@acquamarin acquamarin requested a review from andyfengHKU April 29, 2025 14:17
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (d53c8b2) to head (0dae2c5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5299   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files        1410     1410           
  Lines       61978    61978           
  Branches     7608     7608           
=======================================
+ Hits        53662    53663    +1     
+ Misses       8141     8140    -1     
  Partials      175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented May 1, 2025

Benchmark Result

Master commit hash: d53c8b254f2df3898728950c6a8d4a8f0e0761d7
Branch commit hash: 77e3fc6532ab03046514574f37dd00e49571548b

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 729.09 730.67 -1.59 (-0.22%)
aggregation q28 6555.69 6576.36 -20.67 (-0.31%)
filter q14 125.42 126.37 -0.96 (-0.76%)
filter q15 126.35 132.54 -6.19 (-4.67%)
filter q16 337.30 343.17 -5.86 (-1.71%)
filter q17 448.26 446.31 1.95 (0.44%)
filter q18 1952.81 1952.46 0.36 (0.02%)
filter zonemap-node 87.74 87.14 0.60 (0.69%)
filter zonemap-node-lhs-cast 89.57 89.58 -0.00 (-0.00%)
filter zonemap-node-null 88.91 88.61 0.30 (0.34%)
filter zonemap-rel 5727.38 5790.74 -63.36 (-1.09%)
fixed_size_expr_evaluator q07 685.14 688.24 -3.10 (-0.45%)
fixed_size_expr_evaluator q08 966.31 966.71 -0.41 (-0.04%)
fixed_size_expr_evaluator q09 963.63 964.36 -0.73 (-0.08%)
fixed_size_expr_evaluator q10 261.86 261.83 0.03 (0.01%)
fixed_size_expr_evaluator q11 262.76 261.84 0.92 (0.35%)
fixed_size_expr_evaluator q12 240.78 241.37 -0.59 (-0.24%)
fixed_size_expr_evaluator q13 1566.83 1566.09 0.73 (0.05%)
fixed_size_seq_scan q23 120.12 118.14 1.98 (1.68%)
join q29 754.59 721.04 33.56 (4.65%)
join q30 1618.78 1740.71 -121.93 (-7.00%)
join q31 8.22 6.10 2.13 (34.87%)
join SelectiveTwoHopJoin 49.20 46.09 3.11 (6.74%)
ldbc_snb_ic q35 10.25 9.87 0.38 (3.89%)
ldbc_snb_ic q36 99.56 99.58 -0.03 (-0.03%)
ldbc_snb_is q32 4.62 3.42 1.20 (35.21%)
ldbc_snb_is q33 16.53 14.70 1.83 (12.44%)
ldbc_snb_is q34 1.17 1.26 -0.09 (-7.21%)
limit push-down-limit-into-distinct 1983.68 1926.32 57.37 (2.98%)
multi-rel multi-rel-large-scan 1781.68 1683.13 98.55 (5.86%)
multi-rel multi-rel-lookup 11.20 11.93 -0.73 (-6.13%)
multi-rel multi-rel-small-scan 207.00 173.48 33.52 (19.32%)
order_by q25 128.48 136.11 -7.63 (-5.61%)
order_by q26 441.55 442.04 -0.49 (-0.11%)
order_by q27 1374.20 1369.07 5.14 (0.38%)
recursive_join recursive-join-bidirection 357.04 345.13 11.91 (3.45%)
recursive_join recursive-join-dense 7106.23 5532.93 1573.30 (28.44%)
recursive_join recursive-join-path 23467.11 22921.41 545.70 (2.38%)
recursive_join recursive-join-sparse 9.02 6.88 2.14 (31.03%)
recursive_join recursive-join-trail 6997.92 5682.65 1315.27 (23.15%)
scan_after_filter q01 169.43 174.43 -4.99 (-2.86%)
scan_after_filter q02 153.48 153.37 0.11 (0.07%)
shortest_path_ldbc100 q37 76.98 72.50 4.47 (6.17%)
shortest_path_ldbc100 q38 355.51 379.80 -24.29 (-6.40%)
shortest_path_ldbc100 q39 87.62 86.71 0.91 (1.05%)
shortest_path_ldbc100 q40 551.83 524.37 27.46 (5.24%)
var_size_expr_evaluator q03 2089.74 2078.59 11.15 (0.54%)
var_size_expr_evaluator q04 2261.38 2261.59 -0.21 (-0.01%)
var_size_expr_evaluator q05 2707.95 2706.16 1.79 (0.07%)
var_size_expr_evaluator q06 1334.27 1348.75 -14.48 (-1.07%)
var_size_seq_scan q19 1419.95 1425.64 -5.69 (-0.40%)
var_size_seq_scan q20 2788.66 2818.47 -29.81 (-1.06%)
var_size_seq_scan q21 2241.29 2257.10 -15.81 (-0.70%)
var_size_seq_scan q22 125.35 125.95 -0.59 (-0.47%)

@acquamarin acquamarin merged commit d584f39 into master May 1, 2025
27 checks passed
@acquamarin acquamarin deleted the neo4j-test branch May 1, 2025 02:34
ray6080 pushed a commit that referenced this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants