-
Notifications
You must be signed in to change notification settings - Fork 203
Avoid double-counting errored lines for CSV warning line number #5243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark ResultMaster commit hash:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5243 +/- ##
==========================================
- Coverage 87.00% 87.00% -0.01%
==========================================
Files 1413 1413
Lines 62227 62224 -3
Branches 7619 7614 -5
==========================================
- Hits 54143 54138 -5
- Misses 7911 7913 +2
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark ResultMaster commit hash:
|
Description
We were double counting errored lines when reporting line numbers when copying from CSV, this PR removes the additional counter in the file error handlers.
Contributor agreement