Skip to content

Conversation

royi-luo
Copy link
Contributor

Description

We were double counting errored lines when reporting line numbers when copying from CSV, this PR removes the additional counter in the file error handlers.

Contributor agreement

@royi-luo royi-luo self-assigned this Apr 16, 2025
Copy link

Benchmark Result

Master commit hash: febb45079741a80c66b88facc4dda407f7aa13e0
Branch commit hash: acc7ba7d9e6cd983458d594f912b786d3b31e0c1

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 724.95 732.96 -8.01 (-1.09%)
aggregation q28 6547.80 6581.92 -34.12 (-0.52%)
filter q14 125.13 134.12 -8.99 (-6.71%)
filter q15 125.77 133.68 -7.90 (-5.91%)
filter q16 342.01 351.27 -9.27 (-2.64%)
filter q17 446.62 453.74 -7.12 (-1.57%)
filter q18 1902.89 1924.03 -21.14 (-1.10%)
filter zonemap-node 88.91 98.32 -9.41 (-9.57%)
filter zonemap-node-lhs-cast 88.97 97.35 -8.38 (-8.61%)
filter zonemap-node-null 89.33 97.21 -7.88 (-8.11%)
filter zonemap-rel 5777.60 5521.85 255.75 (4.63%)
fixed_size_expr_evaluator q07 688.21 684.06 4.15 (0.61%)
fixed_size_expr_evaluator q08 969.40 970.20 -0.80 (-0.08%)
fixed_size_expr_evaluator q09 973.53 977.00 -3.47 (-0.36%)
fixed_size_expr_evaluator q10 260.72 262.60 -1.88 (-0.72%)
fixed_size_expr_evaluator q11 263.87 263.38 0.48 (0.18%)
fixed_size_expr_evaluator q12 240.99 241.91 -0.91 (-0.38%)
fixed_size_expr_evaluator q13 1570.75 1563.72 7.04 (0.45%)
fixed_size_seq_scan q23 117.68 119.65 -1.97 (-1.64%)
join q29 670.65 729.22 -58.57 (-8.03%)
join q30 1639.89 1653.85 -13.95 (-0.84%)
join q31 9.45 5.46 3.98 (72.87%)
join SelectiveTwoHopJoin 45.18 55.68 -10.50 (-18.86%)
ldbc_snb_ic q35 10.21 10.32 -0.11 (-1.06%)
ldbc_snb_ic q36 89.50 97.83 -8.33 (-8.51%)
ldbc_snb_is q32 4.85 5.54 -0.69 (-12.43%)
ldbc_snb_is q33 15.46 12.78 2.69 (21.02%)
ldbc_snb_is q34 1.23 1.20 0.03 (2.20%)
limit push-down-limit-into-distinct 2170.92 1836.37 334.55 (18.22%)
multi-rel multi-rel-large-scan 1679.29 1932.86 -253.56 (-13.12%)
multi-rel multi-rel-lookup 10.73 11.29 -0.56 (-4.95%)
multi-rel multi-rel-small-scan 213.51 207.74 5.77 (2.78%)
order_by q25 129.41 135.73 -6.33 (-4.66%)
order_by q26 462.09 457.51 4.58 (1.00%)
order_by q27 1384.20 1390.30 -6.10 (-0.44%)
recursive_join recursive-join-bidirection 297.88 266.97 30.91 (11.58%)
recursive_join recursive-join-dense 7079.90 7017.62 62.28 (0.89%)
recursive_join recursive-join-path 23280.29 23251.41 28.88 (0.12%)
recursive_join recursive-join-sparse 7.53 629.52 -621.99 (-98.80%)
recursive_join recursive-join-trail 7066.07 6964.41 101.67 (1.46%)
scan_after_filter q01 169.72 177.86 -8.14 (-4.57%)
scan_after_filter q02 153.12 163.63 -10.52 (-6.43%)
shortest_path_ldbc100 q37 83.94 91.87 -7.94 (-8.64%)
shortest_path_ldbc100 q38 338.68 323.71 14.97 (4.62%)
shortest_path_ldbc100 q39 88.25 56.27 31.98 (56.84%)
shortest_path_ldbc100 q40 345.52 420.09 -74.57 (-17.75%)
var_size_expr_evaluator q03 2091.30 2121.58 -30.28 (-1.43%)
var_size_expr_evaluator q04 2191.36 2217.58 -26.22 (-1.18%)
var_size_expr_evaluator q05 2712.11 2605.33 106.78 (4.10%)
var_size_expr_evaluator q06 1345.30 1352.19 -6.89 (-0.51%)
var_size_seq_scan q19 1423.76 1434.34 -10.58 (-0.74%)
var_size_seq_scan q20 2723.02 2524.95 198.07 (7.84%)
var_size_seq_scan q21 2277.06 2248.58 28.47 (1.27%)
var_size_seq_scan q22 123.69 127.77 -4.07 (-3.19%)

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.00%. Comparing base (1e2d845) to head (556457e).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5243      +/-   ##
==========================================
- Coverage   87.00%   87.00%   -0.01%     
==========================================
  Files        1413     1413              
  Lines       62227    62224       -3     
  Branches     7619     7614       -5     
==========================================
- Hits        54143    54138       -5     
- Misses       7911     7913       +2     
  Partials      173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Benchmark Result

Master commit hash: 1e2d845c7293a2f5e1ada4963454757d70149e71
Branch commit hash: 05f0a8c433bf0fabb046a16f707299d13c6d5fd9

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 724.86 N/A N/A
aggregation q28 6577.47 N/A N/A
filter q14 128.95 N/A N/A
filter q15 126.56 N/A N/A
filter q16 343.54 N/A N/A
filter q17 445.29 N/A N/A
filter q18 1920.58 N/A N/A
filter zonemap-node 89.91 N/A N/A
filter zonemap-node-lhs-cast 89.79 N/A N/A
filter zonemap-node-null 89.51 N/A N/A
filter zonemap-rel 5894.23 N/A N/A
fixed_size_expr_evaluator q07 690.60 N/A N/A
fixed_size_expr_evaluator q08 971.01 N/A N/A
fixed_size_expr_evaluator q09 973.51 N/A N/A
fixed_size_expr_evaluator q10 261.86 N/A N/A
fixed_size_expr_evaluator q11 262.33 N/A N/A
fixed_size_expr_evaluator q12 241.13 N/A N/A
fixed_size_expr_evaluator q13 1593.86 N/A N/A
fixed_size_seq_scan q23 115.33 N/A N/A
join q29 775.02 N/A N/A
join q30 1791.28 N/A N/A
join q31 6.89 N/A N/A
join SelectiveTwoHopJoin 49.65 N/A N/A
ldbc_snb_ic q35 10.38 N/A N/A
ldbc_snb_ic q36 109.54 N/A N/A
ldbc_snb_is q32 6.51 N/A N/A
ldbc_snb_is q33 13.64 N/A N/A
ldbc_snb_is q34 1.21 N/A N/A
limit push-down-limit-into-distinct 2171.71 N/A N/A
multi-rel multi-rel-large-scan 1669.04 N/A N/A
multi-rel multi-rel-lookup 12.33 N/A N/A
multi-rel multi-rel-small-scan 203.17 N/A N/A
order_by q25 126.80 N/A N/A
order_by q26 463.35 N/A N/A
order_by q27 1370.53 N/A N/A
recursive_join recursive-join-bidirection 330.78 N/A N/A
recursive_join recursive-join-dense 6401.53 N/A N/A
recursive_join recursive-join-path 23640.66 N/A N/A
recursive_join recursive-join-sparse 13.35 N/A N/A
recursive_join recursive-join-trail 6785.08 N/A N/A
scan_after_filter q01 169.79 N/A N/A
scan_after_filter q02 154.36 N/A N/A
shortest_path_ldbc100 q37 97.71 N/A N/A
shortest_path_ldbc100 q38 434.26 N/A N/A
shortest_path_ldbc100 q39 87.45 N/A N/A
shortest_path_ldbc100 q40 365.29 N/A N/A
var_size_expr_evaluator q03 2085.90 N/A N/A
var_size_expr_evaluator q04 2192.95 N/A N/A
var_size_expr_evaluator q05 2713.23 N/A N/A
var_size_expr_evaluator q06 1347.43 N/A N/A
var_size_seq_scan q19 1423.02 N/A N/A
var_size_seq_scan q20 2770.00 N/A N/A
var_size_seq_scan q21 2280.09 N/A N/A
var_size_seq_scan q22 123.99 N/A N/A

@royi-luo royi-luo marked this pull request as ready for review April 17, 2025 12:46
@royi-luo royi-luo requested a review from ray6080 April 17, 2025 12:47
@royi-luo royi-luo merged commit 3ff660e into master Apr 17, 2025
28 checks passed
@royi-luo royi-luo deleted the royi/copy-error-line-number-fix branch April 17, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants