Skip to content

Conversation

benjaminwinger
Copy link
Contributor

@benjaminwinger benjaminwinger commented Mar 7, 2025

It should be safe to use QueryResults after the connection has been destroyed, but it isn't after the Database has been destroyed.

I've also fixed some warnings and bumped the MSRV since clippy helpfully pointed out that we're using a function that has only been stable since rust 1.67.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (4a46184) to head (83a30c9).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5009      +/-   ##
==========================================
- Coverage   87.79%   87.78%   -0.01%     
==========================================
  Files        1412     1412              
  Lines       64547    64547              
  Branches     7562     7562              
==========================================
- Hits        56666    56663       -3     
- Misses       7853     7856       +3     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

It should be safe to use QueryResults after the connection has been destroyed, but it isn't after the Database has been destroyed
Fixed some warnings and also bumped the MSRV to 1.67 since clippy
pointed out that checked_ilog10 has only been stable since then
@benjaminwinger benjaminwinger force-pushed the rust-query-result-lifetime branch from 59c54ad to 83a30c9 Compare March 7, 2025 17:19
Copy link

github-actions bot commented Mar 7, 2025

Benchmark Result

Master commit hash: 8cfb6553038cd144cfb0211783441aac326e4919
Branch commit hash: 22c8c3f64550a886dea8abe1afa8a3879cfefc39

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 725.26 748.66 -23.40 (-3.13%)
aggregation q28 6490.71 7316.74 -826.03 (-11.29%)
filter q14 124.63 155.57 -30.94 (-19.89%)
filter q15 125.82 151.37 -25.55 (-16.88%)
filter q16 341.29 351.07 -9.77 (-2.78%)
filter q17 445.46 453.38 -7.92 (-1.75%)
filter q18 1975.72 1921.66 54.06 (2.81%)
filter zonemap-node 88.34 97.36 -9.02 (-9.27%)
filter zonemap-node-lhs-cast 90.30 97.47 -7.18 (-7.36%)
filter zonemap-node-null 88.90 97.22 -8.32 (-8.56%)
filter zonemap-rel 5619.46 5742.78 -123.32 (-2.15%)
fixed_size_expr_evaluator q07 680.99 695.10 -14.11 (-2.03%)
fixed_size_expr_evaluator q08 967.63 978.62 -10.99 (-1.12%)
fixed_size_expr_evaluator q09 963.73 974.26 -10.53 (-1.08%)
fixed_size_expr_evaluator q10 253.41 270.85 -17.44 (-6.44%)
fixed_size_expr_evaluator q11 254.03 270.22 -16.19 (-5.99%)
fixed_size_expr_evaluator q12 232.50 248.16 -15.66 (-6.31%)
fixed_size_expr_evaluator q13 1596.08 1572.27 23.81 (1.51%)
fixed_size_seq_scan q23 112.56 126.42 -13.85 (-10.96%)
join q29 712.27 962.57 -250.30 (-26.00%)
join q30 1647.70 2178.69 -530.99 (-24.37%)
join q31 4.69 4.82 -0.14 (-2.85%)
join SelectiveTwoHopJoin 48.74 45.07 3.68 (8.16%)
ldbc_snb_ic q35 11.32 10.16 1.17 (11.48%)
ldbc_snb_ic q36 115.26 101.01 14.25 (14.11%)
ldbc_snb_is q32 4.05 3.94 0.11 (2.76%)
ldbc_snb_is q33 11.48 13.69 -2.21 (-16.14%)
ldbc_snb_is q34 1.23 1.15 0.08 (6.88%)
multi-rel multi-rel-large-scan 1399.95 1415.65 -15.70 (-1.11%)
multi-rel multi-rel-lookup 12.43 11.19 1.24 (11.08%)
multi-rel multi-rel-small-scan 199.98 209.17 -9.19 (-4.39%)
order_by q25 126.06 138.81 -12.75 (-9.19%)
order_by q26 448.65 464.55 -15.89 (-3.42%)
order_by q27 1388.04 1409.30 -21.27 (-1.51%)
recursive_join recursive-join-bidirection 309.45 311.90 -2.45 (-0.79%)
recursive_join recursive-join-dense 7161.54 7142.15 19.39 (0.27%)
recursive_join recursive-join-path 23340.68 23743.69 -403.01 (-1.70%)
recursive_join recursive-join-sparse 634.93 898.59 -263.65 (-29.34%)
recursive_join recursive-join-trail 7067.57 7074.84 -7.27 (-0.10%)
scan_after_filter q01 171.10 185.28 -14.18 (-7.65%)
scan_after_filter q02 155.47 166.52 -11.06 (-6.64%)
shortest_path_ldbc100 q37 83.68 102.05 -18.37 (-18.00%)
shortest_path_ldbc100 q38 379.33 336.07 43.26 (12.87%)
shortest_path_ldbc100 q39 65.56 65.48 0.08 (0.13%)
shortest_path_ldbc100 q40 359.08 406.31 -47.23 (-11.62%)
var_size_expr_evaluator q03 2150.93 2113.38 37.55 (1.78%)
var_size_expr_evaluator q04 2261.67 2218.90 42.78 (1.93%)
var_size_expr_evaluator q05 2667.03 2721.70 -54.67 (-2.01%)
var_size_expr_evaluator q06 1345.32 1359.69 -14.37 (-1.06%)
var_size_seq_scan q19 1436.65 1435.45 1.20 (0.08%)
var_size_seq_scan q20 2627.11 2684.94 -57.82 (-2.15%)
var_size_seq_scan q21 2229.11 2246.30 -17.19 (-0.77%)
var_size_seq_scan q22 129.49 128.73 0.76 (0.59%)

@andyfengHKU andyfengHKU merged commit c64f413 into master Mar 8, 2025
28 checks passed
@andyfengHKU andyfengHKU deleted the rust-query-result-lifetime branch March 8, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants