Speed up recompilation when changing compile-time config #4850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royi-luo
force-pushed
the
royi/speed-up-constants-recompilation
branch
from
b9a29d2 to
faaa6bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4850 +/- ##
=======================================
Coverage 86.55% 86.55%
=======================================
Files 1397 1397
Lines 60489 60515 +26
Branches 7452 7453 +1
=======================================
+ Hits 52355 52380 +25
Misses 7966 7966
- Partials 168 169 +1 ☔ View full report in Codecov by Sentry. |
royi-luo
force-pushed
the
royi/speed-up-constants-recompilation
branch
from
97d7645 to
060a86a
Compare
royi-luo
force-pushed
the
royi/speed-up-constants-recompilation
branch
from
060a86a to
e414205
Compare
royi-luo
commented
Feb 6, 2025
Comment on lines
-286
to
-289
| - name: Test with coverage vector capacity of 2 | ||
| run: | | ||
| make lcov VECTOR_CAPACITY_LOG2=1 | ||
|
|
There was a problem hiding this comment.
I realised that this doesn't work since recompiling overwrites the coverage data from previous runs. If we want to include it we'll need to find a way to merge the coverage data from multiple runs from different builds.
Benchmark ResultMaster commit hash:
|
royi-luo
commented
Feb 6, 2025
| @@ -131,6 +131,7 @@ fn build_bundled_cmake() -> Result<Vec<PathBuf>, Box<dyn std::error::Error>> { | |||
| Ok(vec
|
@benjaminwinger can I delegate the review of this PR to you? I don't think I need to be involved here. |
benjaminwinger
approved these changes
Feb 7, 2025
| @@ -131,6 +131,7 @@ fn build_bundled_cmake() -> Result<Vec<PathBuf>, Box<dyn std::error::Error>> { | |||
| Ok(vec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a template file
cmake/templates/system_config.h.inthat uses CMake'sconfigure_filethat is used to generate the header${CMAKE_BINARY_DIR}/src/include/common/system_config.hwhich contains all of our compile-time configurations. Also added${CMAKE_BINARY_DIR}/src/includeas an include directory so that we can include the generated header ascommon/system_config.hThis means that when we recompile with a different configuration, only files that include the generated
system_config.hwill be recompiled (with the existing method of using compile definitions the whole project will be recompiled each time a configuration is changed).Speedup
Master
New
With the current changes I got the number of recompile steps reduced to 569 from 777
I've gotten the speedup to improve to about 220 steps by making changes to the code (e.g. reorganizing includes, moving stuff from header to cpp file) but I'll put that in a separate PR since it's a large change.
Contributor agreement