Skip to content

Conversation

MSebanc
Copy link
Contributor

@MSebanc MSebanc commented Dec 4, 2024

Description

Added type names to shell auto complete

Fixes #4570

Contributor agreement

Copy link

github-actions bot commented Dec 4, 2024

Benchmark Result

Master commit hash: 55a4997150e559ea52e61eff0f480b9a12bbd0f5
Branch commit hash: 455fe836a4782c6dc85ecb7da73cef7a8b806313

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 646.94 646.81 0.13 (0.02%)
aggregation q28 11761.45 11694.97 66.48 (0.57%)
filter q14 125.77 124.24 1.53 (1.23%)
filter q15 125.14 124.11 1.03 (0.83%)
filter q16 302.92 316.21 -13.30 (-4.21%)
filter q17 444.77 443.96 0.81 (0.18%)
filter q18 1941.29 1944.56 -3.27 (-0.17%)
filter zonemap-node 86.18 86.43 -0.25 (-0.28%)
filter zonemap-node-lhs-cast 86.31 88.18 -1.86 (-2.11%)
filter zonemap-rel 5596.59 5567.90 28.69 (0.52%)
fixed_size_expr_evaluator q07 579.18 581.04 -1.86 (-0.32%)
fixed_size_expr_evaluator q08 813.26 808.56 4.71 (0.58%)
fixed_size_expr_evaluator q09 806.63 812.09 -5.46 (-0.67%)
fixed_size_expr_evaluator q10 243.75 245.27 -1.52 (-0.62%)
fixed_size_expr_evaluator q11 237.71 236.25 1.46 (0.62%)
fixed_size_expr_evaluator q12 232.20 236.31 -4.11 (-1.74%)
fixed_size_expr_evaluator q13 1453.57 1450.28 3.29 (0.23%)
fixed_size_seq_scan q23 117.08 115.09 1.99 (1.73%)
join q29 617.50 590.08 27.42 (4.65%)
join q30 1375.19 1380.98 -5.79 (-0.42%)
join q31 3.96 5.39 -1.44 (-26.61%)
ldbc_snb_ic q35 393.63 399.54 -5.91 (-1.48%)
ldbc_snb_ic q36 87.93 133.89 -45.96 (-34.33%)
ldbc_snb_is q32 3.44 2.24 1.20 (53.73%)
ldbc_snb_is q33 13.72 12.11 1.61 (13.33%)
ldbc_snb_is q34 1.51 1.84 -0.33 (-17.94%)
multi-rel multi-rel-large-scan 1188.14 1207.99 -19.85 (-1.64%)
multi-rel multi-rel-lookup 19.98 33.15 -13.17 (-39.73%)
multi-rel multi-rel-small-scan 103.90 104.96 -1.06 (-1.01%)
order_by q25 132.29 128.35 3.94 (3.07%)
order_by q26 472.77 472.12 0.66 (0.14%)
order_by q27 1462.09 1458.26 3.83 (0.26%)
scan_after_filter q01 170.45 169.53 0.91 (0.54%)
scan_after_filter q02 155.08 156.11 -1.03 (-0.66%)
shortest_path_ldbc100 q37 92.52 88.26 4.26 (4.83%)
shortest_path_ldbc100 q38 470.46 467.40 3.05 (0.65%)
shortest_path_ldbc100 q39 60.54 62.35 -1.81 (-2.90%)
shortest_path_ldbc100 q40 551.80 518.86 32.95 (6.35%)
var_size_expr_evaluator q03 2064.45 2072.03 -7.58 (-0.37%)
var_size_expr_evaluator q04 2255.24 2271.59 -16.34 (-0.72%)
var_size_expr_evaluator q05 2676.87 2666.08 10.79 (0.40%)
var_size_expr_evaluator q06 1349.74 1356.17 -6.44 (-0.47%)
var_size_seq_scan q19 1450.04 1449.34 0.69 (0.05%)
var_size_seq_scan q20 2582.08 2582.87 -0.79 (-0.03%)
var_size_seq_scan q21 2272.00 2276.25 -4.25 (-0.19%)
var_size_seq_scan q22 124.87 125.30 -0.43 (-0.34%)

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (4403706) to head (99d0ce4).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4591      +/-   ##
==========================================
- Coverage   87.36%   86.57%   -0.80%     
==========================================
  Files        1358     1373      +15     
  Lines       57112    58078     +966     
  Branches     7126     7221      +95     
==========================================
+ Hits        49898    50281     +383     
- Misses       7050     7631     +581     
- Partials      164      166       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MSebanc MSebanc marked this pull request as ready for review December 21, 2024 07:54
@MSebanc MSebanc requested a review from andyfengHKU December 21, 2024 07:54
Copy link

Benchmark Result

Master commit hash: 2d73b32844103cac544bb01353438e11c5ad6898
Branch commit hash: ec7daefe0a39ba537f0c4419a1a29e1172808740

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 653.24 659.40 -6.17 (-0.94%)
aggregation q28 11869.42 11973.71 -104.29 (-0.87%)
filter q14 126.26 127.72 -1.46 (-1.14%)
filter q15 124.28 135.96 -11.68 (-8.59%)
filter q16 305.97 309.63 -3.66 (-1.18%)
filter q17 454.84 457.55 -2.71 (-0.59%)
filter q18 1973.11 1925.70 47.41 (2.46%)
filter zonemap-node 88.52 91.26 -2.74 (-3.00%)
filter zonemap-node-lhs-cast 90.05 88.59 1.45 (1.64%)
filter zonemap-node-null 86.14 84.72 1.42 (1.68%)
filter zonemap-rel 5748.72 5785.41 -36.69 (-0.63%)
fixed_size_expr_evaluator q07 581.00 578.46 2.54 (0.44%)
fixed_size_expr_evaluator q08 813.74 806.94 6.80 (0.84%)
fixed_size_expr_evaluator q09 808.59 810.77 -2.18 (-0.27%)
fixed_size_expr_evaluator q10 244.28 244.84 -0.56 (-0.23%)
fixed_size_expr_evaluator q11 236.18 237.42 -1.25 (-0.53%)
fixed_size_expr_evaluator q12 233.62 234.28 -0.66 (-0.28%)
fixed_size_expr_evaluator q13 1457.90 1457.35 0.55 (0.04%)
fixed_size_seq_scan q23 120.61 123.06 -2.45 (-1.99%)
join q29 610.41 616.35 -5.95 (-0.96%)
join q30 1546.50 1539.98 6.52 (0.42%)
join q31 4.67 6.84 -2.17 (-31.70%)
join SelectiveTwoHopJoin 47.64 45.69 1.96 (4.28%)
ldbc_snb_ic q35 2604.73 2669.85 -65.12 (-2.44%)
ldbc_snb_ic q36 554.09 520.85 33.24 (6.38%)
ldbc_snb_is q32 5.28 6.01 -0.73 (-12.11%)
ldbc_snb_is q33 13.99 11.45 2.54 (22.21%)
ldbc_snb_is q34 1.19 0.99 0.20 (20.22%)
multi-rel multi-rel-large-scan 1259.56 1227.81 31.74 (2.59%)
multi-rel multi-rel-lookup 9.55 30.81 -21.27 (-69.01%)
multi-rel multi-rel-small-scan 79.89 72.06 7.83 (10.86%)
order_by q25 133.56 133.84 -0.29 (-0.21%)
order_by q26 444.80 452.45 -7.65 (-1.69%)
order_by q27 1470.63 1493.37 -22.74 (-1.52%)
recursive_join recursive-join-bidirection 276.07 269.89 6.18 (2.29%)
recursive_join recursive-join-dense 6860.28 7417.29 -557.01 (-7.51%)
recursive_join recursive-join-path 24175.36 23999.69 175.67 (0.73%)
recursive_join recursive-join-sparse 14154.16 14135.82 18.34 (0.13%)
recursive_join recursive-join-trail 7239.50 7304.14 -64.64 (-0.89%)
scan_after_filter q01 172.09 171.04 1.04 (0.61%)
scan_after_filter q02 155.81 157.27 -1.46 (-0.93%)
shortest_path_ldbc100 q37 91.40 88.79 2.62 (2.95%)
shortest_path_ldbc100 q38 366.44 348.70 17.75 (5.09%)
shortest_path_ldbc100 q39 57.85 70.42 -12.57 (-17.85%)
shortest_path_ldbc100 q40 432.11 380.47 51.64 (13.57%)
var_size_expr_evaluator q03 2068.40 2088.95 -20.55 (-0.98%)
var_size_expr_evaluator q04 2232.29 2243.62 -11.33 (-0.51%)
var_size_expr_evaluator q05 2592.82 2638.84 -46.02 (-1.74%)
var_size_expr_evaluator q06 1343.22 1370.66 -27.44 (-2.00%)
var_size_seq_scan q19 1463.88 1476.94 -13.07 (-0.88%)
var_size_seq_scan q20 2689.19 2739.61 -50.42 (-1.84%)
var_size_seq_scan q21 2280.88 2297.61 -16.73 (-0.73%)
var_size_seq_scan q22 126.54 127.77 -1.24 (-0.97%)

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyfengHKU andyfengHKU merged commit 9dd8083 into master Dec 21, 2024
25 checks passed
@andyfengHKU andyfengHKU deleted the shell-autocomplete-types branch December 21, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cli]: Types missing in autocomplete
2 participants