-
Notifications
You must be signed in to change notification settings - Fork 15k
Generated kubelet reference for v1.34 #52504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: af6724f84685471a9ebbfc89e5f4e06e50e2f5af
|
@tengqm , the commit message has a |
We have been unable to generate reference for kubelet for a loooong time, due to a disruptive refactoring that happened to the upstream source. With the help from soltysh, we are now able to generate it again. This means we don't have to manually sync this command line reference any more. ref: kubernetes-sigs/reference-docs#399
Thanks for spotting that. Fixed. |
</tr> | ||
<tr> | ||
<td></td><td style="line-height: 130%; word-wrap: break-word;">The IP address for the kubelet to serve on (set to <code>0.0.0.0</code> or <code>::</code> for listening on all interfaces and IP address families) (DEPRECATED: This parameter should be set via the config file specified by the kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td> | ||
<td></td><td style="line-height: 130%; word-wrap: break-word;"><p>The IP address for the Kubelet to serve on (set to '0.0.0.0' or '::' for listening on all interfaces and IP address families) (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.)</p></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the links to the docs page aren’t rendering as expected (preview page). They used to appear as anchor tags (current page), but now they’re showing up as plain text HTTPS links (screenshot below for reference). Could this be adjusted so they render properly again?

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a control over the Markdown parser for hyperlinks like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing hyperlinks are shown as hyperlinks because the existing reference was manually tuned.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have been unable to generate reference for kubelet for a loooong time, due to a disruptive refactoring that happened to the upstream source. With the help from soltysh, we are now able to generate it again. This means we don't have to manually sync this command line reference any more.
ref: kubernetes-sigs/reference-docs#399
Description
Issue
Closes: #