Skip to content

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Sep 23, 2025

We have been unable to generate reference for kubelet for a loooong time, due to a disruptive refactoring that happened to the upstream source. With the help from soltysh, we are now able to generate it again. This means we don't have to manually sync this command line reference any more.

ref: kubernetes-sigs/reference-docs#399

Description

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 23, 2025
Copy link

netlify bot commented Sep 23, 2025

Pull request preview available for checking

Name Link
🔨 Latest commit 0de6c90
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68d4aed92a1d330008364129
😎 Deploy Preview https://deploy-preview-52504--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: af6724f84685471a9ebbfc89e5f4e06e50e2f5af

@reylejano
Copy link
Member

@tengqm , the commit message has a @ which is one of the special characters that is not permitted, can you edit the commit message to remove @

We have been unable to generate reference for kubelet for a loooong
time, due to a disruptive refactoring that happened to the upstream
source. With the help from soltysh, we are now able to generate it
again. This means we don't have to manually sync this command line
reference any more.

ref: kubernetes-sigs/reference-docs#399
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 25, 2025
@tengqm
Copy link
Contributor Author

tengqm commented Sep 25, 2025

@tengqm , the commit message has a @ which is one of the special characters that is not permitted, can you edit the commit message to remove @

Thanks for spotting that. Fixed.

</tr>
<tr>
<td></td><td style="line-height: 130%; word-wrap: break-word;">The IP address for the kubelet to serve on (set to <code>0.0.0.0</code> or <code>::</code> for listening on all interfaces and IP address families) (DEPRECATED: This parameter should be set via the config file specified by the kubelet's <code>--config</code> flag. See <a href="https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/">kubelet-config-file</a> for more information.)</td>
<td></td><td style="line-height: 130%; word-wrap: break-word;"><p>The IP address for the Kubelet to serve on (set to '0.0.0.0' or '::' for listening on all interfaces and IP address families) (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.)</p></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the links to the docs page aren’t rendering as expected (preview page). They used to appear as anchor tags (current page), but now they’re showing up as plain text HTTPS links (screenshot below for reference). Could this be adjusted so they render properly again?

links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a control over the Markdown parser for hyperlinks like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing hyperlinks are shown as hyperlinks because the existing reference was manually tuned.

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9ad825f into kubernetes:main Sep 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants