Skip to content

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented May 2, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promoted `generateName` retries to beta, and made the `NameGenerationRetries` feature gate
enabled by default.
You can read https://kep.k8s.io/4420 for more details.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig api-machinery
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 2, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 2, 2024
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented May 2, 2024

/assign @deads2k
This is just a feature gate flip.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@k8s-ci-robot k8s-ci-robot requested review from apelisse and thockin May 2, 2024 13:31
@cici37
Copy link
Contributor

cici37 commented May 2, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented May 6, 2024

matches expectations

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cd1c3efa859ac2d0a6abb44d7cea67fcfb1290ed

@k8s-ci-robot k8s-ci-robot merged commit 54687f3 into kubernetes:master May 6, 2024
@sftim
Copy link
Contributor

sftim commented May 7, 2024

Changelog suggestion

-GenerateName retry is now in beta and enabled by default. Check out https://github.com/kubernetes/enhancements/issues/4420 for more details.
+Promoted `generateName` retries to beta, and made the `NameGenerationRetries` feature gate
+enabled by default.
+You can read https://kep.k8s.io/4420 for more details.

@sftim
Copy link
Contributor

sftim commented May 7, 2024

When we document this change, let's update https://kubernetes.io/docs/reference/using-api/api-concepts/#generated-values with a brief mention of retries.

@jpbetz
Copy link
Contributor Author

jpbetz commented May 7, 2024

When we document this change, let's update https://kubernetes.io/docs/reference/using-api/api-concepts/#generated-values with a brief mention of retries.

Will do. Thanks Tim for you helping get this one done early in the cycle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants