Skip to content

Conversation

nicknagi
Copy link

@nicknagi nicknagi commented Sep 9, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allows handling of MIGs across many GCP projects.

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

GCE: Handle Multiple Projects For MIG Cache

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 9, 2025
Copy link

linux-foundation-easycla bot commented Sep 9, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nicknagi / name: Nekhil Nagia (e4b015c)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nicknagi
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from towca September 9, 2025 21:05
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from x13n September 9, 2025 21:05
@k8s-ci-robot
Copy link
Contributor

Welcome @nicknagi!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @nicknagi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2025
@nicknagi nicknagi marked this pull request as ready for review September 9, 2025 21:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2025
@kwiesmueller
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2025
@nicknagi nicknagi force-pushed the handle-multi-project-mig-cache branch from b1d5bcd to 08e6cdd Compare September 9, 2025 22:27
@nicknagi nicknagi force-pushed the handle-multi-project-mig-cache branch from 08e6cdd to e4b015c Compare September 11, 2025 20:26
@jackfrancis
Copy link
Contributor

@nicknagi you will need to sign the CNCF CLA in order to get this PR moving forward, thanks for the contribution!

@jackfrancis
Copy link
Contributor

/release-note-edit

GCE: Handle Multiple Projects For MIG Cache

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 12, 2025
@nicknagi
Copy link
Author

@nicknagi you will need to sign the CNCF CLA in order to get this PR moving forward, thanks for the contribution!

Ah yes, done!

@jackfrancis
Copy link
Contributor

/assign @yaroslava-serdiuk
/assign @x13n
/assign @BigDarkClown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants