-
Notifications
You must be signed in to change notification settings - Fork 1.6k
✨ feat: Update CronJob and Multiversion tutorials to use Status Conditions #5087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
✨ feat: Update CronJob and Multiversion tutorials to use Status Conditions #5087
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nerdeveloper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @nerdeveloper. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nerdeveloper, thanks for working on this! While we wait for the maintainer’s review, could you take a look at the failing checks? Getting those fixed should help move things along more smoothly. The Coverage (Coveralls) failure looks like a flake, so no worries there. Let me know if there’s anything I can do to help.
ead3582
to
b7c2137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nerdeveloper, thanks for fixing the failing checks! Just one more thing: to keep the commit history clean, could you please squash your commits into a single one?
…tions - Add Status Conditions support following K8s API conventions - Implement meta.SetStatusCondition() throughout reconciliation - Add condition types: Available, Progressing, Degraded - Update tests to verify Status Conditions behavior using hasCondition helper - Add test cases for suspended CronJobs - Fix unused function lint errors in test files This aligns the tutorials with best practices demonstrated in the Deploy Image Plugin example, addressing issue kubernetes-sigs#5024 and kubernetes-sigs#4019.
f695bab
to
5731e44
Compare
This aligns the tutorials with best practices demonstrated in the Deploy Image Plugin example, addressing issue #5024 and #4019.
Note: This PR contains manual changes to the tutorial code. The CI will fail as make generate needs updates (will be handled in a follow-up PR per the proposed solution).