-
Notifications
You must be signed in to change notification settings - Fork 167
Remove check on snapshot create support for multi-writer HyperDisk-HA #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove check on snapshot create support for multi-writer HyperDisk-HA #2116
Conversation
… and let such validations occur at the PD control plane layer
|
Welcome @sumanthsuresh1117! |
Hi @sumanthsuresh1117. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
/approve As a followup, should we add an e2e test that takes a snapshot of a hyperdisk-ha disk? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, sumanthsuresh1117 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Filed b/427994669 |
Remove check on snapshot create support for multi-writer HyperDisk-HA and let such validations occur at the PD control plane layer Author: Sumanth Suresh <[email protected]> Date: Wed Jun 25 23:41:28 2025 +0000
Let such validations occur at the PD control plane layer as the support will evolve/change going forward and it's better for the CSI-driver layer to not test such supportability.
What type of PR is this?
bug
What this PR does / why we need it:
Removes an unnecessary and potentially incorrect check that multi-writer Hyperdisk doesn't support snapshot. Hyperdisk is in the process of supporting this functionality and the CSI-driver must defer such checks to the PD control plane.
Does this PR introduce a user-facing change?: