Skip to content

Conversation

sumanthsuresh1117
Copy link
Contributor

@sumanthsuresh1117 sumanthsuresh1117 commented Jun 25, 2025

Let such validations occur at the PD control plane layer as the support will evolve/change going forward and it's better for the CSI-driver layer to not test such supportability.

What type of PR is this?
bug

What this PR does / why we need it:
Removes an unnecessary and potentially incorrect check that multi-writer Hyperdisk doesn't support snapshot. Hyperdisk is in the process of supporting this functionality and the CSI-driver must defer such checks to the PD control plane.

Does this PR introduce a user-facing change?:

NONE

… and let such validations occur at the PD control plane layer
@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 25, 2025
Copy link

linux-foundation-easycla bot commented Jun 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sumanthsuresh1117 (6760775)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @sumanthsuresh1117!

It looks like this is your first PR to kubernetes-sigs/gcp-compute-persistent-disk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-compute-persistent-disk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @sumanthsuresh1117. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 25, 2025
@tonyzhc tonyzhc self-assigned this Jun 26, 2025
@tonyzhc
Copy link
Contributor

tonyzhc commented Jun 26, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 26, 2025
@tonyzhc
Copy link
Contributor

tonyzhc commented Jun 26, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@msau42
Copy link
Contributor

msau42 commented Jun 26, 2025

/approve

As a followup, should we add an e2e test that takes a snapshot of a hyperdisk-ha disk?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, sumanthsuresh1117

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 28f5cc8 into kubernetes-sigs:master Jun 26, 2025
9 checks passed
@tonyzhc
Copy link
Contributor

tonyzhc commented Jun 26, 2025

/approve

As a followup, should we add an e2e test that takes a snapshot of a hyperdisk-ha disk?

Filed b/427994669

chao007 pushed a commit to chao007/gcp-pd-csi-driver that referenced this pull request Jul 24, 2025
Remove check on snapshot create support for multi-writer HyperDisk-HA and let such validations occur at the PD control plane layer

Author:    Sumanth Suresh <[email protected]>
Date:      Wed Jun 25 23:41:28 2025 +0000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants