Skip to content

Remove no-op Watcher logs for GKE Data Cache in 1.17 release branch #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Remove no-op Watcher logs for GKE Data Cache in 1.17 release branch #2069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/gce-pd-csi-driver/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,6 @@ func createVg(volumeGroupName string, raidedLocalSsds string) error {

func reduceVolumeGroup(volumeGroupName string, force bool) {
if !checkVgExists(volumeGroupName) {
klog.V(2).Infof("Volume group %v not found, no further action needed", volumeGroupName)
return
}
args := []string{
Expand Down Expand Up @@ -646,7 +645,7 @@ func watchDiskDetaches(watcher *fsnotify.Watcher, nodeName string, errorCh chan
case err := <-watcher.Errors:
errorCh <- fmt.Errorf("disk update event errored: %v", err)
// watch for events
case event := <-watcher.Events:
case <-watcher.Events:
// In case of an event i.e. creation or deletion of any new PV, we update the VG metadata.
// This might include some non-LVM changes, no harm in updating metadata multiple times.
args := []string{
Expand All @@ -658,7 +657,6 @@ func watchDiskDetaches(watcher *fsnotify.Watcher, nodeName string, errorCh chan
klog.Errorf("Error updating volume group's metadata: %v", err)
}
reduceVolumeGroup(getVolumeGroupName(nodeName), true)
klog.V(6).Infof("disk attach/detach event %#v\n", event)
}
}
}
Expand Down