Update stable rc master image to point to v1.14.2-rc1 #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/assign @pwschuurman |
k8s-ci-robot
added
the
size/XS
pwschuurman
approved these changes
Aug 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-gcp-compute-persistent-disk-csi-driver-e2e |
amacaskill
force-pushed
the
1.14-release
branch
from
029257a to
41f684e
Compare
k8s-ci-robot
removed
the
lgtm
amacaskill
commented
Aug 14, 2024
| @@ -43,7 +43,7 @@ var ( | |||
| minCpuPlatform = flag.String("min-cpu-platform", "AMD Milan", "Minimum CPU architecture") | |||
| zones = flag.String("zones", "us-east4-a,us-east4-c", "Zones to run tests in. If there are multiple zones, separate each by comma") | |||
| machineType = flag.String("machine-type", "n2d-standard-2", "Type of machine to provision instance on") | |||
| imageURL = flag.String("image-url", "projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2310-amd64", "OS image url to get image from") | |||
| imageURL = flag.String("image-url", "projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2404-lts-amd64", "OS image url to get image from") | |||
There was a problem hiding this comment.
The e2e test was failing with
F0814 21:27:42.152971 8151 setup_e2e_test.go:155] Failed to setup instance gce-pd-csi-e2e-us-east4-a: could not create instance gce-pd-csi-e2e-us-east4-a: API error: googleapi: Error 404: The resource 'projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2310-amd64' was not found, notFound
FAIL sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/test/e2e/tests 60.708s
So I updated to one of the images returned from gcloud compute images list --project=ubuntu-os-cloud | grep ubuntu-minimal
So I'm trying to bump the image and see if that helps
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: