Skip to content

Conversation

Sneha-at
Copy link
Contributor

@Sneha-at Sneha-at commented May 16, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Adds feature to leverage Local SSDs as cache for persistent disks to reduce latency. It uses LVM as caching framework.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added feature to leverage Local SSDs as cache for persistent disks.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 16, 2024
@k8s-ci-robot k8s-ci-robot requested review from leiyiz and mattcary May 16, 2024 22:13
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sneha-at
Once this PR has been reviewed and has the lgtm label, please assign mattcary for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sneha-at
Copy link
Contributor Author

/test all

@Sneha-at Sneha-at changed the title Data cache Add data caching feature with Local SSDs for PD May 16, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 16, 2024
@Sneha-at
Copy link
Contributor Author

/retest

Copy link
Contributor

@mattcary mattcary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we could have a nicer abstraction for all the lvm command sequences to make maintenance easier in the future, but it's fine for now.

Just one small change then lgtm. Thanks for doing the e2e tests.

@Sneha-at
Copy link
Contributor Author

/retest

@Sneha-at
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@Sneha-at
Copy link
Contributor Author

/retest

@Sneha-at
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@mattcary
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

@Sneha-at: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration a27526b link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
pull-gcp-compute-persistent-disk-csi-driver-e2e a27526b link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mattcary
Copy link
Contributor

the e2e test is failing due to an unknown compile failure. It works locally.

The k8s integration snapshot failures are happening on master as well. Since this feature doesn't support snapshot yet we can ignore.

Since this is an experimental branch, force-pushing.

@mattcary mattcary marked this pull request as ready for review May 20, 2024 18:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2024
@mattcary mattcary merged commit cb563a1 into kubernetes-sigs:experimental-release-999 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants