-
Notifications
You must be signed in to change notification settings - Fork 167
Add data caching feature with Local SSDs for PD #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data caching feature with Local SSDs for PD #1711
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Sneha-at The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we could have a nicer abstraction for all the lvm command sequences to make maintenance easier in the future, but it's fine for now.
Just one small change then lgtm. Thanks for doing the e2e tests.
/retest |
/test pull-gcp-compute-persistent-disk-csi-driver-e2e |
/retest |
/test pull-gcp-compute-persistent-disk-csi-driver-e2e |
/retest |
@Sneha-at: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
the e2e test is failing due to an unknown compile failure. It works locally. The k8s integration snapshot failures are happening on master as well. Since this feature doesn't support snapshot yet we can ignore. Since this is an experimental branch, force-pushing. |
What type of PR is this?
What this PR does / why we need it:
Adds feature to leverage Local SSDs as cache for persistent disks to reduce latency. It uses LVM as caching framework.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: