Automated cherry pick of #1586: update driver to support staging compute #1609: fix pointer issue for GCE staging support #1617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
Sneha-at
force-pushed
the
automated-cherry-pick-of-#1586-#1609-upstream-release-1.13
branch
from
32e6511 to
226f947
Compare
k8s-ci-robot
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, Sneha-at The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
amacaskill
reviewed
Feb 22, 2024
|
|
||
| func urlFlag(target **url.URL, name string, usage string) { | ||
| flag.Func(name, usage, func(flagValue string) error { | ||
| computeURL, err := url.ParseRequestURI(flagValue) |
There was a problem hiding this comment.
When "--compute-endpoint" isn't set, this always errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #1586 #1609 on release-1.13.
#1586: update driver to support staging compute
#1609: fix pointer issue for GCE staging support
For details on the cherry pick process, see the cherry pick requests page.