🐛 Stop adding conversion-data annotation to Cluster object #12719
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-cluster-api-e2e-main |
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-fixup-conversion-annotation
branch
from
9d2752c to
884e0ea
Compare
|
/test pull-cluster-api-e2e-main |
|
/lgtm /hold check on artifacts |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7f5cf7a4f17df96a54b25c968c4dff5499558e10
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
|
/override pull-cluster-api-e2e-main Artifacts look good /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.11 |
|
@sbueringer: new pull request created: #12721 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Before this PR the topology controller was adding the conversion-data annotation to the Cluster object.
This happened because:
v1beta1Cluster.ConvertFrom(cluster)in a few code pathsout.ObjectMeta = in.ObjectMetafor conversion. So both objects are updatedWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #