-
Notifications
You must be signed in to change notification settings - Fork 219
fix: wrap error when nodepool update/delete fails #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrap error when nodepool update/delete fails #1364
Conversation
Signed-off-by: Carlos Salas <[email protected]>
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, richardcase, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.8 |
@salasberryfin: new pull request created: #1395 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind bug
What this PR does / why we need it:
Controller logs show an error during reconciliation if GCP-controlled automatic updates are currently running on node pools. This is because the error received from Google's API cannot be unwrapped, even if there is logic in the controller code to check for this failure. Same behavior occurs when deleting a cluster but, in this case, there's no existing logic to handle this API response.
This PR returns the error in an unwrappable format for update operations and adds the same error validation for deletions.
Which issue(s) this PR fixes:
Fixes #1363
Special notes for your reviewer:
TODOs:
Release note: