Skip to content

Bump CAPI to v1.8 #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 14, 2024
Merged

Bump CAPI to v1.8 #1318

merged 7 commits into from
Oct 14, 2024

Conversation

damdo
Copy link
Member

@damdo damdo commented Oct 3, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

CAPI v1.8.0 is out now, so this PRs bumps the CAPI version used by CAPG to it.

Bumps CAPI to v1.8.x based on https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.7-to-v1.8.md

Special notes for your reviewer:
api-diff failing is expected as the API changed to a typed go generics function.

Checklist:

  • squashed commits
  • adds or updates e2e tests

Release note:

Bump CAPI to v1.8.4

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 43c0024
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/670d13aba318cd0008a16238
😎 Deploy Preview https://deploy-preview-1318--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 3, 2024
@damdo damdo force-pushed the capi-1.8 branch 3 times, most recently from 019abf8 to c770694 Compare October 14, 2024 12:07
@damdo damdo changed the title WIP: Bump CAPI to v1.8 Bump CAPI to v1.8 Oct 14, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
@damdo
Copy link
Member Author

damdo commented Oct 14, 2024 •
edited
Loading

api-diff failing is expected as the API changed to a typed go generics function.

@damdo
Copy link
Member Author

damdo commented Oct 14, 2024

/assign @cpanato @richardcase

@richardcase
Copy link
Member

/override pull-cluster-api-provider-gcp-apidiff

@k8s-ci-robot
Copy link
Contributor

@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-gcp-apidiff

In response to this:

/override pull-cluster-api-provider-gcp-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member

/approved

@richardcase
Copy link
Member

Thanks @damdo for this

cpanato
cpanato approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you

i will plan a release for that, do y'all agree?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@damdo
Copy link
Member Author

damdo commented Oct 14, 2024

Yes a release would be awesome @cpanato thanks!

@k8s-ci-robot k8s-ci-robot merged commit 981be9a into kubernetes-sigs:main Oct 14, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Oct 14, 2024
@richardcase
Copy link
Member

i will plan a release for that, do y'all agree?

That would be great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@dims dims Awaiting requested review from dims

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@damdo @richardcase @k8s-ci-robot @cpanato