This repository was archived by the owner on May 6, 2022. It is now read-only.
This repository was archived by the owner on May 6, 2022. It is now read-only.
Panic when async operation exceeds the ReconciliationRetryDuration #2253
Description
Bug Report
What happened:
One ServiceInstance was stuck in the "The instance is being provisioned asynchronously" state for a week:
- lastTransitionTime: 2018-07-25T03:52:10Z
message: The instance is being provisioned asynchronously ()
Once the week has passed (today), Service Catalog controller-manager started crashing in the CrashLoopBackoff.
After analyzing logs, we've found that the panic is due to nil pointer dereferencing in the line https://github.com/kubernetes-incubator/service-catalog/blob/3d0602afb81d872521e527c3aae83e26676b184b/pkg/controller/controller_instance.go#L2392
This happens because readyCond = nil is ALWAYS passed in https://github.com/kubernetes-incubator/service-catalog/blob/3d0602afb81d872521e527c3aae83e26676b184b/pkg/controller/controller_instance.go#L965-L967
What you expected to happen:
No panic