This repository was archived by the owner on Sep 24, 2021. It is now read-only.
README: modify the build step for binaries #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
priority/backlog
k8s-ci-robot
added
the
size/S
Closed
pablochacin
approved these changes
Jun 22, 2019
chuckha
reviewed
Jun 24, 2019
'-o' for directories is still bleeding edge and has some bugs in 1.12. See issue 14295 in https://github.com/golang/go. - Inline separate build commands for the binaries. - Include GO111MODULE=on as it's required if the repo was cloned in GOPATH - Include the binaries in .gitignore
|
updated. |
|
/lgtm thank you ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'-o' for directories is still bleeding edge and has some bugs in 1.12.
See issue 14295 in https://github.com/golang/go.
fixes #9
/priority backlog
/kind documentation
/assign @chuckha