Fix post-kubermatic-update-docs job for KKP release 2.27 and 2.26 #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archana Sawant <[email protected]>
kubermatic-bot
added
dco-signoff: yes
archups
changed the title
kron4eg
reviewed
Sep 19, 2025
hack/render-crds.sh
Outdated
| if [ $gomajorversion -lt $requiredmajorversion ]; then | ||
| echo "running go install github.com/elastic/[email protected] in 5s... (ctrl-c to cancel)" | ||
| sleep 5 | ||
| go install github.com/elastic/[email protected] |
There was a problem hiding this comment.
did you know that one can simply run the module go run github.com/elastic/[email protected]?
CRD_REF_VERSION=v0.1.0
CRD_REF_BIN="go run github.com/elastic/crd-ref-docs@$CRD_REF_VERSION"
$CRD_REF_BIN --params ...Signed-off-by: Archana Sawant <[email protected]>
|
LGTM label has been added. Git tree hash: 9b55227082df603cf5510fdc9a628d056918a191
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #1980 fixed the
post-kubermatic-update-docsprow job failure for KKPmainand 2.28, however broke for the 2.27 and 2.26. This PR is to follow-up to fix post-kubermatic-update-docs-x.xx job failures for KKP release 2.27 and 2.26. When Go version is <1.24, thenproxy.laosky.tk/elastic/[email protected]should be installed instead ofproxy.laosky.tk/elastic/[email protected].