fix(helm): static master ips wouldn't work anymore

[SkalaNetworks]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Features
• Bug fixes
• Docs
• Tests

Which issue(s) this PR fixes

Fixes #5553

[gemini-code-assist]

Summary of Changes

Hello @SkalaNetworks, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I'm addressing a bug where the Helm charts for Kube-OVN would incorrectly fail when static master IPs were configured. Previously, the charts would throw an error if no master nodes were found via labels, even if masterNodes or MASTER_NODES were explicitly provided. This change modifies the logic to ensure that the failure only occurs if neither labeled nodes nor static master IPs are available, thus allowing static master IP configurations to work as intended.

Highlights

• Bug Fix for Static Master IPs: I've implemented a fix to resolve an issue where Kube-OVN Helm charts would incorrectly fail when static master IPs were configured.
• Conditional Logic Adjustment: The core change involves modifying the conditional check in _helpers.tpl files (for both kube-ovn and kube-ovn-v2 charts) that determines if master node IPs are found.
• Improved Master Node IP Resolution: The updated logic now correctly accounts for scenarios where $.Values.masterNodes or $.Values.MASTER_NODES are explicitly set, preventing an unnecessary failure when nodes aren't found via labels.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where statically configured master IPs were not being respected in the Helm charts. The logic to only fail when no master nodes are found via labels and no static IPs are provided is sound. However, a small syntax error was introduced in one of the files, which would cause Helm deployments to fail. I've provided a comment with a fix for this critical issue.