fix NB Global not updated after OVN IC is disabled #5511
Conversation
Signed-off-by: zhangzujian <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @zhangzujian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a bug where the OVN Northbound Global configuration was not being correctly updated after OVN Interconnection (IC) was disabled. The changes enhance error handling and ensure that auto-routing settings are consistently and explicitly propagated to the OVN NB database, improving the reliability of the OVN IC controller's state management.
Highlights
- Error Handling Improvement: The
setAutoRoutefunction has been modified to return an error, allowing for better propagation and handling of potential issues during the configuration of OVN Interconnection auto-routing. - Explicit Auto-Route Disablement: When OVN Interconnection (IC) is disabled, the system now explicitly calls
setAutoRoute(false). This ensures that theNB_Globalconfiguration in the OVN Northbound database is correctly updated to reflect the disabled auto-routing state, addressing a previous bug where this update was missed. - Redundant Assignment Removal: A redundant assignment of
nbGlobal.Optionsto itself has been removed within theSetICAutoRoutefunction. This streamlines the logic by preventing an unnecessary operation when the desired options already match the current in-memory state.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where OVN Northbound Global options were not being cleared when OVN Interconnection (IC) is disabled. The main fix is the addition of a call to setAutoRoute(false) during the IC teardown process. The associated refactoring to propagate errors from setAutoRoute improves the robustness of the controller. Additionally, a cleanup in SetICAutoRoute removes a redundant assignment, enhancing code quality.
| if maps.Equal(options, nbGlobal.Options) { | ||
| nbGlobal.Options = options | ||
| return nil | ||
| } |
There was a problem hiding this comment.
The assignment nbGlobal.Options = options is not needed before returning. If the options are equal, there is no need to update the nbGlobal options, so returning early is correct and avoids an unnecessary update.
Pull Request Test Coverage Report for Build 16460092191Details
💛 - Coveralls |
dosubot
bot
added
the
size:S
Signed-off-by: zhangzujian <[email protected]>
Signed-off-by: zhangzujian <[email protected]>
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)