fix: ip/vpc are not deleted by helm uninstall

[oilbeater]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Bug fixes

Which issue(s) this PR fixes

Fixes #(issue-number)

[gemini-code-assist]

Summary of Changes

Hello @oilbeater, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug that prevented ip and vpc resources from being properly cleaned up when the kube-ovn Helm chart was uninstalled. It achieves this by updating the Helm pre-delete hook to execute a new, generalized script responsible for removing finalizers from subnet, vpc, and ip objects, ensuring a complete and clean uninstallation process.

Highlights

• Resource Cleanup Fix: This pull request addresses a bug where ip and vpc custom resources were not being deleted during helm uninstall operations of Kube-OVN, leading to orphaned resources in the cluster.
• Enhanced Finalizer Removal: The existing Helm pre-delete hook, which previously only handled subnet finalizers, has been updated to utilize a new, more comprehensive script. This new script ensures that finalizers are removed from subnet, vpc, and ip resources, guaranteeing their proper cleanup upon uninstallation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a script to remove finalizers from ip and vpc resources during helm uninstall. The RBAC permissions for the pre-delete hook need to be updated to allow modifying ip and vpc resources. The cleanup script can be improved for better maintainability and robustness.

[coveralls]

Pull Request Test Coverage Report for Build 16414518284

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.004%) to 21.433%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/ovs/ovn-nb-logical_router_route.go	2	74.6%

Totals
Change from base Build 16412918337:	-0.004%
Covered Lines:	10540
Relevant Lines:	49176

---

💛 - Coveralls