Skip to content

Conversation

oilbeater
Copy link
Contributor

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @oilbeater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines and updates the project's documentation. It removes outdated information regarding kube-ovn-pinger arguments and introduces a crucial warning about the deprecation of STT tunnel support in Open vSwitch, ensuring users are aware of upcoming changes and unsupported features.

Highlights

  • Documentation Removal: Removed documentation files related to kube-ovn-pinger arguments (kube-ovn-pinger-args.en.md and kube-ovn-pinger-args.md).
  • STT Tunnel Deprecation Warning: Added a warning to the tunnel-protocol documentation (both English and Chinese versions) indicating that Open vSwitch upstream has removed support for STT tunnels in version 3.6, implying future lack of support.
  • Navigation Update: Updated mkdocs.yml to remove the kube-ovn-pinger argument documentation from the site navigation and search index.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the documentation for kube-ovn-pinger arguments and adds a deprecation warning for STT tunnels. The changes are logical and improve the documentation by removing obsolete information and warning users about a deprecated feature. I have provided a few minor suggestions to improve the wording and formatting of the new warning messages for better clarity and consistency.

@@ -33,6 +33,10 @@ and consumes more CPU resources when handling large packets.

## STT

!!! warning

Open vSwitch upstream removed support for STT tunnels in version 3.6 [commit](https://github.com/openvswitch/ovs/commit/19b89416203f3b3b212fb01c30c81ea1b77624eb){: target="_blank" }. This solution will no longer receive upstream support in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase "in the future" is redundant because "will no longer" already implies a future state. Removing it will make the sentence more concise.

Suggested change
Open vSwitch upstream removed support for STT tunnels in version 3.6 [commit](https://github.com/openvswitch/ovs/commit/19b89416203f3b3b212fb01c30c81ea1b77624eb){: target="_blank" }. This solution will no longer receive upstream support in the future.
Open vSwitch upstream removed support for STT tunnels in version 3.6 [commit](https://github.com/openvswitch/ovs/commit/19b89416203f3b3b212fb01c30c81ea1b77624eb){: target="_blank" }. This solution will no longer receive upstream support.

Comment on lines 34 to 36
OpenVswitch 上游在 3.6 版本[移除对 STT 类型 Tunnel 的支持](https://github.com/openvswitch/ovs/commit/19b89416203f3b3b212fb01c30c81ea1b77624eb){: target="_blank" },该方案未来将无法得到上游支持。


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

I have a few suggestions to improve this warning message for clarity and consistency:

  1. Naming: For consistency with the official name, "OpenVswitch" should be "Open vSwitch".
  2. Conciseness: The word 未来 (future) is redundant, as 将无法 already implies the future. It can be removed.
  3. Formatting: There is an extra blank line that can be removed to match the formatting of the English version.
Suggested change
OpenVswitch 上游在 3.6 版本[移除对 STT 类型 Tunnel 的支持](https://github.com/openvswitch/ovs/commit/19b89416203f3b3b212fb01c30c81ea1b77624eb){: target="_blank" },该方案未来将无法得到上游支持
Open vSwitch 上游在 3.6 版本[移除对 STT 类型 Tunnel 的支持](https://github.com/openvswitch/ovs/commit/19b89416203f3b3b212fb01c30c81ea1b77624eb){: target="_blank" },该方案将无法得到上游支持

@oilbeater oilbeater merged commit f263d2c into master Sep 10, 2025
2 checks passed
@oilbeater oilbeater deleted the tunnel branch September 10, 2025 02:54
oilbeater added a commit that referenced this pull request Sep 10, 2025
Signed-off-by: Mengxin Liu <[email protected]>
(cherry picked from commit f263d2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant