Skip to content

Conversation

oilbeater
Copy link
Contributor

Signed-off-by: Mengxin Liu <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @oilbeater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the performance tuning documentation to align with recent changes in Open vSwitch support and to improve usability. The primary goal is to inform users about the deprecation of the STT tunnel type and to provide updated instructions for Open vSwitch compilation, alongside minor enhancements to external link navigation.

Highlights

  • STT Tunnel Deprecation Warning: A new warning has been added to the performance tuning documentation (both English and Chinese versions) to inform users that Open vSwitch upstream has removed support for STT-type tunnels in version 3.6, indicating that this solution will no longer receive upstream support.
  • Open vSwitch Version Update: The documentation has been updated to reflect the latest recommended Open vSwitch branch for compilation, changing from branch-2.17 to branch-3.5 for cloning the OVS repository and updating the corresponding RPM package name.
  • External Link Behavior Improvement: External links within the performance tuning documentation have been modified to open in a new browser tab, enhancing user experience.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the performance tuning documentation by adding a deprecation warning for STT tunnels, updating Open vSwitch versions, and improving external links. My review focuses on correcting a typo in a command and improving the wording of the new warning for better clarity and accuracy in both English and Chinese versions of the document.


!!! warning

OpenVswitch 上游在 3.6 版本[移除对 STT 类型 Tunnel 的支持](https://github.com/openvswitch/ovs/commit/19b89416203f3b3b212fb01c30c81ea1b77624eb){: target="_blank" },该方案未来将无法得到上游支持。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and correctness, please update the project name from "OpenVswitch" to "Open vSwitch". Additionally, "STT 类型 Tunnel" could be simplified to "STT 隧道" to be more idiomatic in Chinese. The link text could also be improved for better grammar.

Suggested change
OpenVswitch 上游在 3.6 版本[移除对 STT 类型 Tunnel 的支持](https://github.com/openvswitch/ovs/commit/19b89416203f3b3b212fb01c30c81ea1b77624eb){: target="_blank" },该方案未来将无法得到上游支持。
Open vSwitch 上游在 3.6 版本[移除了对 STT 隧道的支持](https://github.com/openvswitch/ovs/commit/19b89416203f3b3b212fb01c30c81ea1b77624eb){: target="_blank" },该方案未来将无法得到上游支持。

oilbeater and others added 2 commits September 9, 2025 17:12
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@oilbeater oilbeater merged commit 5b0ed95 into master Sep 9, 2025
2 checks passed
@oilbeater oilbeater deleted the perf/deprecated branch September 9, 2025 09:14
oilbeater added a commit that referenced this pull request Sep 9, 2025
* deprecate warning about stt

Signed-off-by: Mengxin Liu <[email protected]>

* Update docs/advance/performance-tuning.en.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update docs/advance/performance-tuning.en.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Signed-off-by: Mengxin Liu <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
(cherry picked from commit 5b0ed95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant