fix(backend): Fix the pipeline samples #11967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After making name and display_name separate fields in the API, the pipeline sample upload code needed to accomodate that, otherwise it would try to upload the pipeline without a display name, which is a required field. The backwards compatibility was handled at the API server level but this code bypassed the API server endpoints and used the resource manager directly. Signed-off-by: mprahl <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mprahl
added a commit
to mprahl/pipelines
that referenced
this pull request
Jun 10, 2025
After making name and display_name separate fields in the API, the pipeline sample upload code needed to accomodate that, otherwise it would try to upload the pipeline without a display name, which is a required field. The backwards compatibility was handled at the API server level but this code bypassed the API server endpoints and used the resource manager directly. Signed-off-by: mprahl <[email protected]> (cherry picked from commit b477269)
2 tasks
openshift-merge-bot bot
added a commit
to opendatahub-io/data-science-pipelines
that referenced
this pull request
Jun 11, 2025
Cherry-pick: fix(backend): Fix the pipeline samples (kubeflow#11967)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
After making name and display_name separate fields in the API, the pipeline sample upload code needed to accomodate that, otherwise it would try to upload the pipeline without a display name, which is a required field. The backwards compatibility was handled at the API server level but this code bypassed the API server endpoints and used the resource manager directly.
Checklist: