feat(proto): Add WorkspaceConfig and KubernetesWorkspaceConfig message types to pipeline_spec proto #11921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
reviewed
May 21, 2025
mprahl
reviewed
May 21, 2025
VaniHaripriya
force-pushed
the
pipeline_spec_update
branch
2 times, most recently
from
e8eb48c to
4f299c3
Compare
HumairAK
reviewed
May 21, 2025
HumairAK
reviewed
May 21, 2025
VaniHaripriya
force-pushed
the
pipeline_spec_update
branch
from
c035162 to
1adb334
Compare
HumairAK
reviewed
May 21, 2025
api/v2alpha1/pipeline_spec.proto
Outdated
Comment on lines
1109
to
1111
| // Example: "250GB" | ||
| string size = 1; |
There was a problem hiding this comment.
How about using the K8S quantity format instead? e.g.
100Gi, 100G, etc.
cc @mprahl
even though you can have multiple implementations, I do like k8s methods of being able to disambiguate between decimalSI and binarySI forms
VaniHaripriya
force-pushed
the
pipeline_spec_update
branch
from
1adb334 to
7651f29
Compare
HumairAK
reviewed
May 21, 2025
…e types to pipeline_spec proto Signed-off-by: VaniHaripriya <[email protected]>
VaniHaripriya
force-pushed
the
pipeline_spec_update
branch
from
7651f29 to
5b569b2
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Checklist: