Skip to content

Conversation

mai-nakagawa
Copy link
Contributor

@mai-nakagawa mai-nakagawa commented May 9, 2025

Description of your changes:

Fixes: #10592.

compiler_utils.get_dependencies function validates name attribute each task in _channel_inputs. The bug is that it tries to retrieve the name attribute even if the task is None.

A similar fix was already introduced in another PR #11476. However, the contributor has not responded to the requests to rebase and to add tests for months.

Checklist:

Copy link

Hi @mai-nakagawa. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented May 9, 2025

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@mai-nakagawa mai-nakagawa changed the title Handles the case when channel is None correctly fix(sdk): Resolves issue when using ParallelFor with param and depending tasks May 9, 2025
@mai-nakagawa mai-nakagawa marked this pull request as ready for review May 9, 2025 06:19
@google-oss-prow google-oss-prow bot requested a review from zazulam May 9, 2025 06:19
@zazulam
Copy link
Collaborator

zazulam commented May 9, 2025

/ok-to-test

Copy link
Collaborator

@zazulam zazulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this
/lgtm

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mai-nakagawa.

/lgtm

cc @mprahl

Copy link
Collaborator

@mprahl mprahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ef94ccd into kubeflow:master May 9, 2025
36 checks passed
@mai-nakagawa mai-nakagawa deleted the patch-1 branch May 9, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] Error compiling with ParallelFor and PipelineParam
4 participants