feat(backend): Add the Kubernetes native pipeline store #11881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
This also improves cache update race conditions in the webhooks. Co-authored-by: Matt Prahl <[email protected]> Signed-off-by: Ricardo M. Oliveira <[email protected]>
Signed-off-by: mprahl <[email protected]>
Signed-off-by: mprahl <[email protected]>
mprahl
force-pushed
the
k8s-native-store
branch
from
b575350 to
d6bde85
Compare
Some tests set the viper configuration of POD_NAMESPACE while others didn't and so the order of the tests mattered. This now sets and resets the viper configuration for each test. Signed-off-by: mprahl <[email protected]>
mprahl
force-pushed
the
k8s-native-store
branch
from
1ce9b15 to
765de9f
Compare
2 tasks
This is more important for the Kubernetes pipeline store. Signed-off-by: mprahl <[email protected]>
mprahl
force-pushed
the
k8s-native-store
branch
from
dfa18d8 to
88bf945
Compare
The KFP UI automatically uses the first port listed in the ml-pipeline Service to communicate with the KFP API. Using a JSON patch to add the webhook port ensures it doesn't change the order. Signed-off-by: mprahl <[email protected]>
mprahl
force-pushed
the
k8s-native-store
branch
from
fa908e5 to
009b1b9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This also improves cache update race conditions in the webhooks.
The first commit is from @rimolive in #11746. Since he's not able to address the remaining feedback, this PR supersedes it with a couple of additional commits to address the feedback.
This also changes the suggested pipeline version name in the frontend to be a valid Kubernetes name:
Checklist: