Skip to content

Conversation

mprahl
Copy link
Collaborator

@mprahl mprahl commented Feb 27, 2025

Description of your changes:

The KFP SDK execution tests weren't using the SDK from the pull request. Additionally, this commit adds support for choosing the right SDK in forks.

Checklist:

The KFP SDK execution tests weren't using the SDK from the pull request.
Additionally, this commit adds support for choosing the right SDK in
forks.

Signed-off-by: mprahl <[email protected]>
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mprahl mprahl changed the title WIP: Use the correct SDK version in the CI Use the correct SDK version in the SDK execution tests CI Feb 27, 2025
@mprahl mprahl marked this pull request as ready for review February 27, 2025 21:57
@mprahl
Copy link
Collaborator Author

mprahl commented Feb 27, 2025

/cc @hbelmiro

@google-oss-prow google-oss-prow bot requested a review from hbelmiro February 27, 2025 21:58
Copy link
Collaborator

@zazulam zazulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HumairAK
Copy link
Collaborator

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, zazulam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 355f78c into kubeflow:master Feb 28, 2025
47 checks passed
@mprahl mprahl deleted the use-latest-sdk-in-ci branch February 28, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants