chore: use local proto go packages for ci #11629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HumairAK
force-pushed
the
local_proto
branch
3 times, most recently
from
b895437 to
2cf4a5f
Compare
|
I worry about this since we may forget to update the actual go.mod after a PR with an API change is merged. My suggestion is to use a replace in the |
HumairAK
force-pushed
the
local_proto
branch
from
2cf4a5f to
cba9017
Compare
HumairAK
force-pushed
the
local_proto
branch
from
cba9017 to
0272686
Compare
|
I'm good with that, updated. |
|
looking into ci failures |
Signed-off-by: Humair Khan <[email protected]>
HumairAK
force-pushed
the
local_proto
branch
from
0272686 to
b623558
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chahatsagarmain
added a commit
to chahatsagarmain/pipelines
that referenced
this pull request
Feb 20, 2025
parent 7bb0c44 author chahatsagarmain <[email protected]> 1740067717 +0530 committer chahatsagarmain <[email protected]> 1740068190 +0530 parent 7bb0c44 author chahatsagarmain <[email protected]> 1740067717 +0530 committer chahatsagarmain <[email protected]> 1740068098 +0530 make commands for local testing and ci refactor Signed-off-by: chahatsagarmain <[email protected]> chore: use local proto go packages for ci (kubeflow#11629) Signed-off-by: Humair Khan <[email protected]> fix(backend): upgrade go version to 1.22.12 to fix CVE-2024-45336 (kubeflow#11631) Signed-off-by: Daniel Dowler <[email protected]> fix(backend) fix run retry for argo (kubeflow#11585) Signed-off-by: arpechenin <[email protected]> fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files (kubeflow#11623) * fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files Signed-off-by: muzzlol <[email protected]> * test(frontend): update NewPipelineVersion snapshot for file filters Signed-off-by: muzzlol <[email protected]> --------- Signed-off-by: muzzlol <[email protected]> fix(backend): fixes DAG status update to reflect completion of all tasks (kubeflow#11651) Signed-off-by: VaniHaripriya <[email protected]> chore(test): Increased timeout in test (kubeflow#11658) Signed-off-by: Helber Belmiro <[email protected]> make commands to test locally and ci refactor Signed-off-by: chahatsagarmain <[email protected]>
chahatsagarmain
added a commit
to chahatsagarmain/pipelines
that referenced
this pull request
Feb 20, 2025
parent 7bb0c44 author chahatsagarmain <[email protected]> 1740067717 +0530 committer chahatsagarmain <[email protected]> 1740068190 +0530 parent 7bb0c44 author chahatsagarmain <[email protected]> 1740067717 +0530 committer chahatsagarmain <[email protected]> 1740068098 +0530 make commands for local testing and ci refactor Signed-off-by: chahatsagarmain <[email protected]> chore: use local proto go packages for ci (kubeflow#11629) Signed-off-by: Humair Khan <[email protected]> fix(backend): upgrade go version to 1.22.12 to fix CVE-2024-45336 (kubeflow#11631) Signed-off-by: Daniel Dowler <[email protected]> fix(backend) fix run retry for argo (kubeflow#11585) Signed-off-by: arpechenin <[email protected]> fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files (kubeflow#11623) * fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files Signed-off-by: muzzlol <[email protected]> * test(frontend): update NewPipelineVersion snapshot for file filters Signed-off-by: muzzlol <[email protected]> --------- Signed-off-by: muzzlol <[email protected]> fix(backend): fixes DAG status update to reflect completion of all tasks (kubeflow#11651) Signed-off-by: VaniHaripriya <[email protected]> chore(test): Increased timeout in test (kubeflow#11658) Signed-off-by: Helber Belmiro <[email protected]> make commands to test locally and ci refactor Signed-off-by: chahatsagarmain <[email protected]> add missing step Signed-off-by: chahatsagarmain <[email protected]>
chahatsagarmain
added a commit
to chahatsagarmain/pipelines
that referenced
this pull request
Feb 27, 2025
parent 7bb0c44 author chahatsagarmain <[email protected]> 1740067717 +0530 committer chahatsagarmain <[email protected]> 1740068190 +0530 parent 7bb0c44 author chahatsagarmain <[email protected]> 1740067717 +0530 committer chahatsagarmain <[email protected]> 1740068098 +0530 make commands for local testing and ci refactor Signed-off-by: chahatsagarmain <[email protected]> chore: use local proto go packages for ci (kubeflow#11629) Signed-off-by: Humair Khan <[email protected]> fix(backend): upgrade go version to 1.22.12 to fix CVE-2024-45336 (kubeflow#11631) Signed-off-by: Daniel Dowler <[email protected]> fix(backend) fix run retry for argo (kubeflow#11585) Signed-off-by: arpechenin <[email protected]> fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files (kubeflow#11623) * fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files Signed-off-by: muzzlol <[email protected]> * test(frontend): update NewPipelineVersion snapshot for file filters Signed-off-by: muzzlol <[email protected]> --------- Signed-off-by: muzzlol <[email protected]> fix(backend): fixes DAG status update to reflect completion of all tasks (kubeflow#11651) Signed-off-by: VaniHaripriya <[email protected]> chore(test): Increased timeout in test (kubeflow#11658) Signed-off-by: Helber Belmiro <[email protected]> make commands to test locally and ci refactor Signed-off-by: chahatsagarmain <[email protected]> add missing step Signed-off-by: chahatsagarmain <[email protected]> reviewed changes Signed-off-by: chahatsagarmain <[email protected]>
chahatsagarmain
added a commit
to chahatsagarmain/pipelines
that referenced
this pull request
Feb 27, 2025
parent 7bb0c44 author chahatsagarmain <[email protected]> 1740067717 +0530 committer chahatsagarmain <[email protected]> 1740068190 +0530 parent 7bb0c44 author chahatsagarmain <[email protected]> 1740067717 +0530 committer chahatsagarmain <[email protected]> 1740068098 +0530 make commands for local testing and ci refactor Signed-off-by: chahatsagarmain <[email protected]> chore: use local proto go packages for ci (kubeflow#11629) Signed-off-by: Humair Khan <[email protected]> fix(backend): upgrade go version to 1.22.12 to fix CVE-2024-45336 (kubeflow#11631) Signed-off-by: Daniel Dowler <[email protected]> fix(backend) fix run retry for argo (kubeflow#11585) Signed-off-by: arpechenin <[email protected]> fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files (kubeflow#11623) * fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files Signed-off-by: muzzlol <[email protected]> * test(frontend): update NewPipelineVersion snapshot for file filters Signed-off-by: muzzlol <[email protected]> --------- Signed-off-by: muzzlol <[email protected]> fix(backend): fixes DAG status update to reflect completion of all tasks (kubeflow#11651) Signed-off-by: VaniHaripriya <[email protected]> chore(test): Increased timeout in test (kubeflow#11658) Signed-off-by: Helber Belmiro <[email protected]> make commands to test locally and ci refactor Signed-off-by: chahatsagarmain <[email protected]> add missing step Signed-off-by: chahatsagarmain <[email protected]> reviewed changes Signed-off-by: chahatsagarmain <[email protected]> fix eol Signed-off-by: chahatsagarmain <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This adds a simple change to allow our CI to reference the local proto packages. This will prevent ci failures when:
Instead, this pr will now reference the updated proto changes locally present within the PR itself.
Checklist: