fix(flows): avoid failing flow dependencies with dynamic defaults #11166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-mulier-p
force-pushed
the
fix/flow-dependencies-with-dynamic-default
branch
from
f1c9d8a to
c25cda3
Compare
|
🐋 Docker image: docker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:11166 server local |
1 similar comment
|
🐋 Docker image: docker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:11166 server local |
brian-mulier-p
force-pushed
the
fix/flow-dependencies-with-dynamic-default
branch
from
c25cda3 to
e9bae98
Compare
|
🐋 Docker image: docker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:11166 server local |
|
loicmathieu
reviewed
Sep 9, 2025
anna-geller
approved these changes
Sep 9, 2025
brian-mulier-p
force-pushed
the
fix/flow-dependencies-with-dynamic-default
branch
from
e9bae98 to
e596479
Compare
|
🐋 Docker image: docker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:11166 server local |
brian-mulier-p
deleted the
fix/flow-dependencies-with-dynamic-default
branch
brian-mulier-p
added a commit
that referenced
this pull request
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11117
The main issue is that input defaults are trying to get resolved but if themselves depend on another inputs it's getting painful.
A better way may be to do the same as for resolve input endpoint or resolve other input defaults while keeping track of failed input resolutions and create a new renderer with the resolved input values and keep iterating till the failure list is no longer reducing or empty but it feels overkill and I don't think handling this case is useful as it's failing only in a "static" context (flow dependencies computing)