fix: include project root in package.path so requires work #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the CWD is not the project root, `require("lib.Demojify")` would
fail because lua cant find the file.
We add the data-dir argument when needed, setting it to the lib
folder, which contains an init.lua file. This init.lua file prepends the
project root to the package.path which allows `require("lib.Demojify")`
to succeed.
kdheepak
reviewed
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CWD is not the panvimdoc directory,
require("lib.Demojify")would fail because lua cant find the file.We add the data-dir argument when needed, setting it to the lib folder, which contains an init.lua file. This init.lua file prepends the project root to the package.path which allows
require("lib.Demojify")to succeed.The
..is a bit awkward, you might prefer to put the init.lua in the main project root instead and alter as needed.